Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If PATH were to be not, program doesn't work.(on windows) #199

Open
etilltwice opened this issue Jan 17, 2019 · 9 comments
Open

If PATH were to be not, program doesn't work.(on windows) #199

etilltwice opened this issue Jan 17, 2019 · 9 comments

Comments

@etilltwice
Copy link

When I commit above command, I got no answer.

PS C:\Users\twice\Desktop\XXX> pt http

But I were to commit under command, it work without problem.

PS C:\Users\twice\Desktop\XXX> pt html ./
./\html\game.html
1:<!DOCTYPE html>
2:<html lang="en">
97:</html>

./\html\index.html
1:<!DOCTYPE html>
2:<html>
19:</html>

development environment

OS:windows 10 Home
version: 1803
software: visual studio code (power shell)

@monochromegane
Copy link
Owner

Thanks!
Would you teach pt version to me?

@monochromegane
Copy link
Owner

Can I try pt html not pt http ?
I think your directory dose not contain http keyword .

@etilltwice
Copy link
Author

I'm sorry not to commit same code.
And, I forgot to tell the version.
It doesn't work when commit same code.

PS C:\Users\twice\Desktop\XXX> pt html

the_platinum_searcher version: 2. 2. 0

@monochromegane
Copy link
Owner

monochromegane commented Jan 17, 2019

Nice information.
And... could you try the following command?

$ pt html .

Windows dose not represent . as current directory? If so that, pt ought to replace .. to ./.

@etilltwice
Copy link
Author

I would be happy to.
It seems that it works without error.

PS C:\Users\twice\Desktop\XXX> pt html .
.\html\game.html
1:<!DOCTYPE html>
2:<html lang="en">
97:</html>

.\html\index.html
1:<!DOCTYPE html>
2:<html>
19:</html>

@monochromegane
Copy link
Owner

monochromegane commented Jan 17, 2019

Hmm...
Please take time.
I don't have Windows environment.
I consider this another day.

@monochromegane
Copy link
Owner

Hi, if you have command prompt (DOS), could you try pt html in the environment?

@ocitrev
Copy link

ocitrev commented Jul 2, 2019

The function givenStdin has a special case for Windows when it should not. Removing the OS check fixes the bug.

@arijoon
Copy link

arijoon commented Feb 17, 2020

This issue still persists, although I don't think it's neccesarily an issue, specifying path shouldn't be a problem. Can you please add it to the README.md? Just a simple note under windows that for windows users PATH option is required.

I installed from github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants