Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collections breaks Objection #220

Open
erothmayer opened this issue Mar 26, 2019 · 4 comments
Open

collections breaks Objection #220

erothmayer opened this issue Mar 26, 2019 · 4 comments

Comments

@erothmayer
Copy link

Installing collections@latest (currently 5.1.8) alongside Objection (a DB ORM) causes unexpected failures. It looks like it's probably due to a regression in the Array.find behavior (#165) which has been reported several times, as it works correctly if I install [email protected]

@erothmayer
Copy link
Author

Also #185

@codebling
Copy link

codebling commented Apr 15, 2019

See also issues #36 #70 #94 #95 #116 #139 #145 #162 #165 #169 #178 #182 #185 #197 #215 #220 and PRs #94 #95 #116 #173 #189 #212. Branch v2 fixes these issues by avoiding global object modification.

@mrsurname
Copy link

Same issue for me
Vincit/objection.js#1350

@ssantanuberaa
Copy link

Also check the section 14.6, there is a prototype based fast-map in the index.js file. I guess it is supposed to mark the map in the fast-map object.
And that's whey the previous issue on the fast-map object mapping was not working.
This can be fixed by calling the following method --
addFastMap(prototype.fastMap[index]);
Here index is the map index in the fast-map array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants