-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep history, diff, etc. #4
Comments
Do you think that minidoms can be successfully cloned using https://github.com/imbcmdth/UltraDeepClone , for example? |
It seems that minidoms can be successfully cloned using I'm looking for a diff/patch solution that can handle the circular references in minidom objects. All of these go into infinite recursion:
flitbit/diff#24 doesn't go into infinite recursion but I didn't quite get my head around it, yet. |
Saw the comment "didn't quite get my head around it", so: see flitbit/diff lines 102-104. A stack is passed along during descent and consulted at every point in a path in order to detect/avoid circular reference problems such as an infinite loop. |
Thank you @flitbit . |
The stack approach is sloppy. Should use a Map or some such. See: https://github.com/kriskowal/pop-clone If this discussion does not require any action, please close. cc @Stuk. |
How would you keep a history of changes in a minidom?
appendChild
, etc.)The text was updated successfully, but these errors were encountered: