feat: add support for struct type #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While attempting to setup this resository, the devcontainer image couldn't be buit because of missing debian archive. This is simply changing the source list URLs to fix the build.
Upgrade the Go starlark package to latest one. This involves a rewrite of the test_configure.py since the starlark resolver configuration is evaluated part of the exec. This is because using global config vars is deprecated now. This is not replacing the usage of it yet as it would involve breaking change of the API.
callum-oakley
previously approved these changes
Feb 9, 2024
romain-h
force-pushed
the
support-struct
branch
from
218a6a6 to
78ec4f6
Compare
romain-h
force-pushed
the
support-struct
branch
from
78ec4f6 to
da082dc
Compare
callum-oakley
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is adding support for Starlark struct type: https://github.com/google/starlark-go/tree/master/starlarkstruct
It binds in both directions to Python SimpleNamespace. This is also using the latest release of
starlark-go.