Skip to content

Commit 6353c0c

Browse files
committed
renames DSL module to Dsl
1 parent d73d6f2 commit 6353c0c

File tree

6 files changed

+16
-10
lines changed

6 files changed

+16
-10
lines changed

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
## [Unreleased]
22

3+
- Rename `Sidekiq::Rescue::DSL` to `Sidekiq::Rescue::Dsl`
4+
35
## [0.1.0] - 2024-01-20
46

57
- Initial release

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ end
3737
```ruby
3838
class MyJob
3939
include Sidekiq::Job
40-
include Sidekiq::Rescue::DSL
40+
include Sidekiq::Rescue::Dsl
4141

4242
sidekiq_rescue ExpectedError
4343

@@ -54,7 +54,7 @@ You can configure the number of retries and the delay (in seconds) between retri
5454
```ruby
5555
class MyJob
5656
include Sidekiq::Job
57-
include Sidekiq::Rescue::DSL
57+
include Sidekiq::Rescue::Dsl
5858

5959
sidekiq_rescue ExpectedError, delay: 60, limit: 5
6060

lib/sidekiq/rescue.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@ module Sidekiq
44
# Sidekiq::Rescue is a Sidekiq plugin which allows you to easily handle
55
# exceptions thrown by your jobs.
66
#
7-
# To use Sidekiq::Rescue, you need to include Sidekiq::Rescue::DSL module
7+
# To use Sidekiq::Rescue, you need to include Sidekiq::Rescue::Dsl module
88
# in your job class and use the sidekiq_rescue class method to define
99
# exception handlers.
1010
#
1111
# class MyJob
1212
# include Sidekiq::Job
13-
# include Sidekiq::Rescue::DSL
13+
# include Sidekiq::Rescue::Dsl
1414
#
1515
# sidekiq_rescue NetworkError, delay: 60, limit: 10
1616
#

lib/sidekiq/rescue/dsl.rb

+7-3
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@
22

33
module Sidekiq
44
module Rescue
5-
# This module is included into the job class to provide the DSL for
5+
# This module is included into the job class to provide the Dsl for
66
# configuring rescue options.
7-
module DSL
7+
module Dsl
88
def self.included(base)
99
base.extend(ClassMethods)
1010
base.sidekiq_class_attribute(:sidekiq_rescue_options)
1111
end
1212

13-
# Module containing the DSL methods
13+
# Module containing the Dsl methods
1414
module ClassMethods
1515
# Configure rescue options for the job.
1616
# @param error [StandardError] The error class to rescue.
@@ -62,5 +62,9 @@ def validate_limit_argument(limit)
6262
end
6363
end
6464
end
65+
# Alias for Dsl; TODO: remove in 1.0.0
66+
# @deprecated
67+
# @see Dsl
68+
DSL = Dsl
6569
end
6670
end

spec/sidekiq/rescue/dsl_spec.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
# frozen_string_literal: true
22

3-
RSpec.describe Sidekiq::Rescue::DSL do
3+
RSpec.describe Sidekiq::Rescue::Dsl do
44
let(:job_class) do
55
Class.new do
66
include Sidekiq::Job
7-
include Sidekiq::Rescue::DSL
7+
include Sidekiq::Rescue::Dsl
88
end
99
end
1010

spec/support/jobs.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
class BaseJob
44
include Sidekiq::Job
5-
include Sidekiq::Rescue::DSL
5+
include Sidekiq::Rescue::Dsl
66
end
77

88
class WithTestErrorJob < BaseJob

0 commit comments

Comments
 (0)