Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP auth handler complete drops POST data #148

Open
VincentVanlaer opened this issue Jan 11, 2023 · 2 comments
Open

HTTP auth handler complete drops POST data #148

VincentVanlaer opened this issue Jan 11, 2023 · 2 comments

Comments

@VincentVanlaer
Copy link

I had the following situation occur on Firefox (110.0a1 (2023-01-10)):

  1. Visit some page protected with basic auth
  2. Fill in some form on that page
  3. Restart the browser for some reason (updates, crash, ...)
  4. Due to session restore, the page is loaded and the form can be completed further, but the basic auth credentials are gone
  5. Submit the form, get redirected to the mooltipass extension page
  6. Login
  7. Notice that something has gone wrong, the form does not appear to be submitted and is empty
  8. Try to use the back button to get back to the form, notice that the form is no longer filled (which is not how firefox normally operates, forms are restored when you use the back button)

It looks like the basic auth page does not look at the HTTP method at all and assumes that the request is a GET request. Quick fix would be to not intercept the request if the HTTP method is anything but GET. The user will then see the standard basic auth login, but at least not lose their data.

@limpkin
Copy link
Contributor

limpkin commented Sep 5, 2024

is this still happening?

@VincentVanlaer
Copy link
Author

Yes. The version of the extensions I am currently running is 1.10.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants