From 261a8c0e35ae6b5245ef3338493b96eb3b931cc6 Mon Sep 17 00:00:00 2001 From: Mathieu Date: Sun, 21 Apr 2024 20:05:17 +0200 Subject: [PATCH 1/2] trying (yet again) to fix travis iOS build --- scripts/ci/osx/install.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/ci/osx/install.sh b/scripts/ci/osx/install.sh index b8a34b4e..29b4bc40 100755 --- a/scripts/ci/osx/install.sh +++ b/scripts/ci/osx/install.sh @@ -7,8 +7,8 @@ brew install jq lftp brew uninstall wget brew install wget echo "Current PATH: $PATH" -pip3 install --upgrade pip -pip3 install aqtinstall -t /Users/travis/aqt +pip3 install --break-system-packages --upgrade pip +pip3 install --break-system-packages aqtinstall -t /Users/travis/aqt export PYTHONPATH=$PYTHONPATH:/Users/travis/aqt /Users/travis/aqt/bin/aqt install-qt mac desktop 6.2.4 clang_64 -m all -O /Users/travis/Qt networksetup -setv6off Ethernet From dae2059124f958d5fea77dbf711b6af524d69b76 Mon Sep 17 00:00:00 2001 From: deXol Date: Mon, 22 Apr 2024 20:08:39 +0200 Subject: [PATCH 2/2] Fix adding TOTP for multiple domain service --- src/MPDevice.cpp | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/MPDevice.cpp b/src/MPDevice.cpp index 39ca6ff0..3e5e1c55 100755 --- a/src/MPDevice.cpp +++ b/src/MPDevice.cpp @@ -7827,8 +7827,15 @@ void MPDevice::setMMCredentials(const QJsonArray &creds, bool noDelete, int keyAfterLogin = 0; int keyAfterPwd = 0; QString multipleDomains = ""; + QString servicePwd = service; if (isBLE()) { + multipleDomains = qjobject["multiple_domains"].toString(); + // For multiple domain we need the add the first domain to service name for password save + if (!multipleDomains.isEmpty()) + { + servicePwd += Common::getFirstDomain(multipleDomains); + } category = qjobject["category"].toInt(); keyAfterLogin = qjobject["key_after_login"].toInt(); keyAfterPwd = qjobject["key_after_pwd"].toInt(); @@ -7842,20 +7849,13 @@ void MPDevice::setMMCredentials(const QJsonArray &creds, bool noDelete, if (!totpObject["totp_secret_key"].toString().isEmpty()) { - bleImpl->createTOTPCredMessage(service, login, qjobject["totp"].toObject()); + bleImpl->createTOTPCredMessage(servicePwd, login, qjobject["totp"].toObject()); } } QJsonArray pointedToAddr = qjobject["pointed_to_child"].toArray(); for (qint32 j = 0; j < pointedToAddr.size(); j++) { pointedToAddrArray.append(pointedToAddr[j].toInt()); } - - multipleDomains = qjobject["multiple_domains"].toString(); - } - QString servicePwd = service; - // For multiple domain we need the add the first domain to service name for password save - if (!multipleDomains.isEmpty()) - { - servicePwd += Common::getFirstDomain(multipleDomains); } + for (qint32 j = 0; j < addrArray.size(); j++) { nodeAddr.append(addrArray[j].toInt()); } qDebug() << "MMM Save: tackling " << login << " for service " << service << " at address " << nodeAddr.toHex();