Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding extra spaces to passwords when ' or " are used in the password #1221

Open
Drakx opened this issue Apr 18, 2024 · 13 comments
Open

Adding extra spaces to passwords when ' or " are used in the password #1221

Drakx opened this issue Apr 18, 2024 · 13 comments

Comments

@Drakx
Copy link
Contributor

Drakx commented Apr 18, 2024

Expected behaviour

No extra spaces to be added

Take the following example, used as a password produced via the extension
bL/jG1-$5xgov)wz/]X'g}C|dnqu(ey

Please note that this has been changed already and is no longer in use.

Actual behaviour

Password will be added with an extra space

bL/jG1-$5xgov)wz/]X 'g}C|dnqu(ey

Notice the extra space between "X 'g" This happens when using any website where this is filled in for the password field.
Because this was an actual password that has since been changed that got reported as incorrect I used Notepad to type out the credentials everything was correct until that extra space.
Viewing the password in the credentials in the app looks to be correct

Step-by-step guide to reproduce the problem

Windows 10
Firefox Developer Edition
Mooltipass Extension installed
Moolticute installed
Under device settings for Moolticute set Bluetooth and USB keyboard Layout to US International

Moolticute Version

1.03.0 Bundle version 13

Operating System

Mention if you are using either:

  • Windows 10

Mooltipass Extension

  • If you're creating an issue to report a website incompatibility, please use the "Report incompatibilities with this website" item in the extension menu.
  • If you're creating an issue to report a problem with our extension, please create another issue here:
    https://github.com/mooltipass/extension/issues

Mooltipass Device

  • The Mooltipass Mini BLE
@Drakx
Copy link
Contributor Author

Drakx commented Apr 18, 2024

Digging a liitle more in to this issue, I have noticed that this bug appears in any password that contains the following characters
" or '
Extra spaces are inputted when none should exist.
The screenshot shows that there appers to be no spaces, but when used in notpad the following is produced
You' havea" space!here
https://ibb.co/M1cNFHZ

I'm yet to confirm that this is the same for macOS.

@Drakx Drakx changed the title Adding extra spaces to passwords Adding extra spaces to passwords when ' or " are used in the password Apr 18, 2024
@limpkin
Copy link
Collaborator

limpkin commented Apr 18, 2024

this looks like a dead key issue where the device types an extra space for special characters.... but can't be sure because the step by step guide is incomplete.
are you using a special keyboard layout

@Drakx
Copy link
Contributor Author

Drakx commented Apr 18, 2024

Yes, I use Dvorak as my layout, configured by the keyboard, Windows set to ENG US International.
What steps would you need to replicate the issue?

@limpkin
Copy link
Collaborator

limpkin commented Apr 18, 2024

I think you should set the keyboard layout to dvorak in moolticute settings then :)

@Drakx
Copy link
Contributor Author

Drakx commented Apr 18, 2024

I have and that produces the following

kd;k f;dolamd kjg;ra;;,soh,gppqja.dQa";raid

As you can see from the screenshot, this is wrong
https://ibb.co/b6TGQWt

When set back to US international for USB keyboard layout
test username thispasswordwill' have@ a"space

the username matches but thats it.

@limpkin
Copy link
Collaborator

limpkin commented Apr 18, 2024

I think I may need to add a setting to disable the dead keys feature on the Mini BLE....
Did you install any kind of software on your computer regarding your dvorak keyboard? standard windows behavior with US layout is when typing " then the character won't be typed right away

@Drakx
Copy link
Contributor Author

Drakx commented Apr 19, 2024

I use https://www.zsa.io/moonlander/ and configured it with https://configure.zsa.io/moonlander/layouts/ no other software is used to configure the keyboard. Luckily this keyboard allows me to configure it using their configurator which allows me to set the OS to my preferred language choice without having to set the OS to Dvorak.

@Drakx
Copy link
Contributor Author

Drakx commented Apr 19, 2024

I think I've found a workaround. Setting the keyboard to UK (MacOS) seems to be working as expected.

@limpkin
Copy link
Collaborator

limpkin commented Apr 19, 2024

that's... odd.

@limpkin
Copy link
Collaborator

limpkin commented Apr 21, 2024

should I close the issue?
From the mini ble side of things, there shouldn't be a difference regarding dead keys between us & uk layouts :/

@Drakx
Copy link
Contributor Author

Drakx commented Apr 21, 2024 via email

@limpkin
Copy link
Collaborator

limpkin commented Apr 21, 2024

makes sense

@TheGreatBeginner777
Copy link

interesting :) . I had this issue mooltipass/minible#263
my workaround was to make new Password profile excluding problematic character. The rest is working fine and as expected...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants