internal: refactor package filter

[lijunchen]

Type of Pull Request

• Bug fix
• New feature
  • I have already discussed this feature with the maintainers.
• Refactor
• Performance optimization
• Documentation
• Other (please describe):

[Young-Flash]

maybe we could remove the filter here? to get the real all packages

[peter-jerry-ye-code-review]

Based on the provided git diff output, here are the key observations and suggestions for improvement:

1. Consistent Use of Package Access Methods:

   • There is a recurring pattern where methods like get_all_packages(), contains_package(), get_package_by_name(), get_filtered_packages(), and others are being used instead of directly accessing the packages field. This suggests a refactoring where the direct access to packages is deprecated in favor of more controlled and potentially more feature-rich methods.
   • Suggestion: Ensure that all parts of the codebase adhere to this new pattern to maintain consistency and leverage the added functionalities provided by these methods.

2. Filtering Logic for Packages:

   • The filtering logic for packages during tests (filter_package) is being refactored to use a more dynamic approach with a filter function rather than a direct check against a static list.
   • Suggestion: This change enhances flexibility and readability. Ensure that all relevant parts of the codebase are updated to use the new get_package_filter() method consistently.

3. Optimization and Readability:

   • The refactoring includes changes to reduce code duplication, especially in the generation of build options and lists. This improves maintainability and readability.
   • Suggestion: Continuously review the codebase for opportunities to further reduce duplication and improve readability. Consider using helper functions or macros to encapsulate common patterns.

Overall, these changes indicate a move towards a more encapsulated and controlled access pattern to the packages field, which should improve the maintainability and flexibility of the codebase. Ensuring consistency in adhering to these new patterns across the codebase will be key to realizing these benefits.