From a68a613880588c452fa5a58616a4a226c2dbc86a Mon Sep 17 00:00:00 2001 From: rahul <609380+rahul27@users.noreply.github.com> Date: Wed, 8 Sep 2021 16:24:35 -0700 Subject: [PATCH] Removed the square wire runtime requirement (#3) * Removed the square wire runtime requirement added a pom.xml dependency that should automatically pull in the runtime dependency. * fixed the github token permissions --- README.md | 10 ++-------- buildSrc/src/main/java/Versions.kt | 1 - sample-app/build.gradle.kts | 1 - 3 files changed, 2 insertions(+), 10 deletions(-) diff --git a/README.md b/README.md index 910c316..b4ceef4 100644 --- a/README.md +++ b/README.md @@ -7,7 +7,7 @@ This repository includes a sample app that demonstrates the use of the Moonsense ## TLDR - Clone this repository. -- Generate a [personal access token](https://docs.github.com/en/github/authenticating-to-github/keeping-your-account-and-data-secure/creating-a-personal-access-token) on Github with `repo` permissions. +- Generate a [personal access token](https://docs.github.com/en/github/authenticating-to-github/keeping-your-account-and-data-secure/creating-a-personal-access-token) on Github with `read:packages` permissions. - Add your Github `username` and `token` as a gradle property. The easiest way to do this is to add the following lines to `~/.gradle/gradle.properties` ```gradle gpr.user= @@ -43,7 +43,7 @@ The library has been hosted using [Github Packages](https://github.com/features/ } ``` -Since the access to the maven repository is restricted you will need to include your `username` and [personal access token](https://docs.github.com/en/github/authenticating-to-github/keeping-your-account-and-data-secure/creating-a-personal-access-token) to reference the SDK library. Details around generating a personal access token can be found [here](https://docs.github.com/en/github/authenticating-to-github/keeping-your-account-and-data-secure/creating-a-personal-access-token)). Make sure you grant `repo` access to reference the library. Once you have the `username` and `token` add it to your gradle properties. The easiest way is to add the following lines to `~/.gradle/gradle.properties`: +Since the access to the maven repository is restricted you will need to include your `username` and [personal access token](https://docs.github.com/en/github/authenticating-to-github/keeping-your-account-and-data-secure/creating-a-personal-access-token) to reference the SDK library. Details around generating a personal access token can be found [here](https://docs.github.com/en/github/authenticating-to-github/keeping-your-account-and-data-secure/creating-a-personal-access-token)). Make sure you grant `read:packages` access to reference the library. Once you have the `username` and `token` add it to your gradle properties. The easiest way is to add the following lines to `~/.gradle/gradle.properties`: ```gradle gpr.user= @@ -59,12 +59,6 @@ With the credentials in place your are ready to include the following line to ad implementation("io.moonsense:android-sdk:0.1.0-alpha2") ``` -Note that the SDK also depends on the square wire runtime. We have to manually add it in as dependency as well: - -```gradle -implementation("com.squareup.wire:wire-runtime:3.7.0") -``` - ## Usage The SDK needs to be initialized before it can be used. Use the `initialize()` method in either an `Application.onCreate()` or `Activity.onCreate()` to prepare the SDK for recording. The `initialize()` call expects a `publicToken` that can be generated using the [Moonsense Console](https://console.moonsense.cloud/). In order to obtain a token you need to: diff --git a/buildSrc/src/main/java/Versions.kt b/buildSrc/src/main/java/Versions.kt index 24fa049..d80300c 100644 --- a/buildSrc/src/main/java/Versions.kt +++ b/buildSrc/src/main/java/Versions.kt @@ -10,5 +10,4 @@ object Versions { const val junitAndroidX = "1.1.3" const val espressoCore = "3.4.0" const val constraintLayout = "2.1.0" - const val squareWireRuntime = "3.7.0" } \ No newline at end of file diff --git a/sample-app/build.gradle.kts b/sample-app/build.gradle.kts index 32ed687..5cd30f6 100644 --- a/sample-app/build.gradle.kts +++ b/sample-app/build.gradle.kts @@ -41,7 +41,6 @@ android { dependencies { implementation("io.moonsense:android-sdk:${AppConfig.versionName}") - implementation("com.squareup.wire:wire-runtime:${Versions.squareWireRuntime}") implementation("androidx.constraintlayout:constraintlayout:${Versions.constraintLayout}") testImplementation("junit:junit:${Versions.junit}") androidTestImplementation("androidx.test.ext:junit:${Versions.junitAndroidX}")