Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scroll jumping #5

Open
moonshinegloss opened this issue Nov 20, 2022 · 1 comment
Open

scroll jumping #5

moonshinegloss opened this issue Nov 20, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@moonshinegloss
Copy link
Owner

moonshinegloss commented Nov 20, 2022 •
edited
Loading

currently because a new element is injected for the "reveal prompt" it slightly jumps your scrollbar when scrolling up during overlaying.

to avoid complicated placeholdering, it would be best if the prompt button is inside the image height (absolute positioned) at first and then when it's opened takes its space with regular positioning above the image.
@moonshinegloss moonshinegloss added enhancement New feature or request good first issue Good for newcomers labels Nov 20, 2022
@moonshinegloss
Copy link
Owner Author

could be addressed with a similar popup like civitai has it

image

this would require most likely a checkbox styling, since discord does not allow in-line click handlers

it should also automatically split apart common details like "negative prompt" into their own read-only textboxes

moonshinegloss added a commit that referenced this issue Feb 9, 2023
@moonshinegloss
update v3.0
7002453 
- much better displaying of parameters and prompt in the vein of idea in #5 however not yet with a new reveal button
- fix possible xss vulnerability
moonshinegloss added a commit that referenced this issue Feb 17, 2023
@moonshinegloss
update v3.1
703d5b6 
- fix new discord layout (closes #8)
- fix incorrect splits of metadata (closes #9)
- added modal to replace the old popout, while keeping the original reveal prompt button (hence still not addressing #5 fully, but implementing the idea of civitai inside)
- make metadata automatically take more space if above 30 characters (useful for e.g. positive and negative prompts)
@retromoustache retromoustache mentioned this issue Feb 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@moonshinegloss