Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong Browser.platform reported for Windows Phone 8.1 #2678

Open
odysseuscm opened this issue Nov 22, 2014 · 6 comments · May be fixed by #2689
Open

Wrong Browser.platform reported for Windows Phone 8.1 #2678

odysseuscm opened this issue Nov 22, 2014 · 6 comments · May be fixed by #2689
Labels
bug mobile
Milestone
1.5.3

Comments

@odysseuscm
Copy link

odysseuscm commented Nov 22, 2014 •
edited by arian
Loading

Hello, I only got one Windows Phone with the latest developer update but for it mootools reports
Browser.platform == 'ios'
The other values are correct: Browser.name == 'ie', Browser.version == '11'

The user agent for IE on this phone is:
Mozilla/5.0 (Mobile; Windows Phone 8.1; Android 4.0; ARM; Trident/7.0; Touch; rv:11.0; IEMobile/11.0; SAMSUNG; GT-I8750) like iPhone OS 7_0_3 Mac OS X AppleWebKit/537 (KHTML, like Gecko) Mobile Safari/537

In my opinion the reported platform should be 'winphone'.
Maybe others with (older) windows phones could check as well.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/6434098-wrong-browser-platform-reported-for-windows-phone-8-1?utm_campaign=plugin&utm_content=tracker%2F22067&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F22067&utm_medium=issues&utm_source=github).
@SergioCrisostomo
Copy link
Member

@odysseuscm I don't have Windows Phone 8.1, could you post back what you get in this jsFiddle: http://jsfiddle.net/90k49fms/show/

@odysseuscm
Copy link
Author

Sure
User Agent: Mozilla/5.0 (Mobile; Windows Phone 8.1; Android 4.0; ARM; Trident/7.0; Touch; rv:11.0; IEMobile/11.0; SAMSUNG; GT-I8750) like iPhone OS 7_0_3 Mac OS X AppleWebKit/537 (KHTML, like Gecko) Mobile Safari/537
Platform: ARM

Getting closer ;-)

@SergioCrisostomo SergioCrisostomo added this to the 1.5.2 milestone Nov 24, 2014
@SergioCrisostomo SergioCrisostomo linked a pull request Jan 11, 2015 that will close this issue
Open
@GCheung55 GCheung55 added the bug label Jan 14, 2015
@odysseuscm
Copy link
Author

Hi, I'm curious why the fix hasn't been merged into 1.5.2 before release?

@SergioCrisostomo SergioCrisostomo modified the milestones: 1.5.2, 1.5.3 Sep 14, 2015
@SergioCrisostomo
Copy link
Member

@odysseuscm i supose no one had time to review/test the pull request.
I tagged it to 1.5.3 and in the meantime you could use the fix in the pull request.

cheers,
sérgio

@odysseuscm
Copy link
Author

mootools 1.6.0 (and 1.6.1dev) still report "ios" for Windows Phone.

@SergioCrisostomo
Copy link
Member

@odysseuscm I made a fix suggestion, now we need a dev to give 👍 and/or merge, or provide a better suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug mobile
Projects
None yet
Milestone
1.5.3
Development

Successfully merging a pull request may close this issue.

UA fix for Windows Phone 8.1 / IE11 SergioCrisostomo/mootools-core
3 participants
@GCheung55 @odysseuscm @SergioCrisostomo