Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all images are checks #317

Open
atonks2 opened this issue Aug 10, 2023 · 1 comment
Open

Not all images are checks #317

atonks2 opened this issue Aug 10, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@atonks2
Copy link
Collaborator

atonks2 commented Aug 10, 2023

ICL files can include images that are not checks, such as deposit slips. Because they're not check images or returns, they are not preceded by a CheckDetail (type 25) or ReturnDetail (type 31) record. This library assumes that all images are associated with checks or returns, so when it encounters an image without a preceding check or return detail it returns an error.

What were you trying to do?

Upload an x937 file containing an image of a deposit ticket. The file in question is valid according to the x9.100-187_UCD-2008 specification companion document.

The file contains the following:

File Header (01)
    Cash Letter Header (10)
        Bundle Header (20)
            Credit (61)
                Image View Detail (50) - Deposit Ticket
                Image View Data (52)
                Image View Detail (50)
                Image View Data (52)
            Check Detail (25)
                Image View Detail (50) - Check 1
                Image View Data (52)
                Image View Detail (50)
                Image View Data (52)
            Check Detail (25)
                Image View Detail (50) - Check 2
                Image View Data (52)
                Image View Detail (50)
                Image View Data (52)
        Bundle Trailer (70)
    Cash Letter Control (90)
File Trailer (99)

What did you expect to see?

A successful file upload.

What did you see?

A FileError was returned from here

{"error":"error reading image cache letter: line:5 record:ImageViewDetail *imagecashletter.FileError ImageViewDetail Outside of current bundle"}

How can we reproduce the problem?

POST a file containing an image outside of a CheckDetail.

@atonks2
Copy link
Collaborator Author

atonks2 commented Aug 11, 2023

Essentially a duplicate of #112

@adamdecaf adamdecaf added the enhancement New feature or request label Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants