Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency checks on launch #494

Open
mithusingh32 opened this issue Nov 11, 2024 · 1 comment
Open

Add dependency checks on launch #494

mithusingh32 opened this issue Nov 11, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@mithusingh32
Copy link

mithusingh32 commented Nov 11, 2024

I think this is a potential enhancement to have the script check for dependencies, particularly zenity.

I'm running on Neon LTS, and zenity is not installed. Took my a few minutes realize why the script was not working. I think having a clear message on launch like "Zenity not detected! Exiting launcher"

I'm not proud it took me so long to discover that since all i got from terminal was "zenity: command not found" and that didn't automatically trigger "Oh im missing a dependency"

I also think exiting on ANY Failure might be a good idea too. (Adding set -e to the top of script or just having checks to perform any rollback if necessary)

@moraroy
Copy link
Owner

moraroy commented Nov 16, 2024

@mithusingh32 will look into fixing this thank you!

@moraroy moraroy added the enhancement New feature or request label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants