Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruamel.yaml dependency on Python 3.8-dev should be maintainable or disabled #289

Closed
jayvdb opened this issue Jul 12, 2019 · 3 comments
Closed

Comments

@jayvdb
Copy link
Member

jayvdb commented Jul 12, 2019

Travis job for 3.8-dev was removed in ec48af4

Following on from #274 , it is quite likely that there will be another breaking change Cpython 3.8, or in Cython on CPython 3.8, requiring ruamel.yaml to be updated otherwise it fails.

If we add dependency ruamel.yaml>=0.15.98;python_version == '3.8', the minreqs version is ruamel.yaml==0.15.98;python_version == '3.8', and that will fail before Python 3.8 is finally released.

Removing the MINREQ Python 3.8-dev job is one option. Currently the .travis template job matrix doesnt support customisation. The template has other problems too moremoban/pypi-mobans#95

Another approach is for the requirement of ruamel.yaml to be hg+https://bitbucket.org/ruamel/yaml#egg=ruamel.yaml;python_version == '3.8', so that the latest version is always used, preventing caching , but

  1. this doesnt work in setup.py where setup_use_markers mode is enabled, at least with old setuptools, as the extra name should be ruamel.yaml and dependency_links used for URLs.
  2. it also probably doesnt work in setup.py where setup_use_markers mode is not enabled, for similar reasons as above.

coala-mobans has some template voodoo to help with the above, but it will take time to get that across into pypi-mobans.

Another, possibly simpler approach, is for minreqs template to omit pins for 3.8. Then the builds should pass as soon as ruamel.yaml releases a new version, and usually he is quite quick in doing releases.

@chfw
Copy link
Member

chfw commented Aug 17, 2019

released in 0.5.0

@chfw chfw closed this as completed Aug 17, 2019
@jayvdb
Copy link
Member Author

jayvdb commented Aug 19, 2019

This is a post-0.5.0 problem which still exists.

@jayvdb jayvdb reopened this Aug 19, 2019
@chfw
Copy link
Member

chfw commented Aug 18, 2020

stale issue

@chfw chfw closed this as completed Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants