Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Data contours from histogram data #67

Open
morganjwilliams opened this issue Nov 10, 2021 · 0 comments
Open

Feature: Data contours from histogram data #67

morganjwilliams opened this issue Nov 10, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@morganjwilliams
Copy link
Owner

Currently contours are only generated by pyroplot.density where mode="density", which uses kernel density estimates to then generate the contours; an error will now result if contours are requested for other modes (largely the topic of #65). These could also be generated from histogram data, although would be much more susceptible to noise in the data.

A few rearrangements would allow the generation of histogram-based contours (with e.g. mode="hist2d", contours=[0.5]) and passing the histogram data to the contouring function (and maybe even mode="hexbin", although the positional accuracy would need to be validated for this). One of these would be to separate the histogram generation from the plotting (both the histogram and hexbin methods are directly using the matplotlib functions ax.hexbin and ax.hist2d), and making sure that the right coordinates are used for contouring (either edge or center points).

@morganjwilliams morganjwilliams added the enhancement New feature or request label Nov 10, 2021
@morganjwilliams morganjwilliams self-assigned this Nov 10, 2021
@morganjwilliams morganjwilliams added this to the 0.3.2 milestone Nov 10, 2021
@morganjwilliams morganjwilliams modified the milestones: 0.3.2, 0.3.3 Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant