Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

array.H: include cstdint to fix llvm 12+ build #452

Merged
merged 1 commit into from Jan 25, 2024
Merged

array.H: include cstdint to fix llvm 12+ build #452

merged 1 commit into from Jan 25, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 25, 2024

include cstdint in arrah.H to fix build errors when compiling with llvm-12+.

include/hobbes/util/array.H:325:22: error: unknown type name 'uint8_t'

@ghost ghost mentioned this pull request Jan 25, 2024
13 tasks
@mo-xiaoming
Copy link
Contributor

Hi @a-n-n-a-l-e-e , for the moment, hobbes doesn't support llvm12+, at least not officially

@ghost
Copy link
Author

ghost commented Jan 25, 2024

Hi @a-n-n-a-l-e-e , for the moment, hobbes doesn't support llvm12+, at least not officially

thats fine -- no harm in adding the header that is responsible for uint8_t tho.
https://en.cppreference.com/w/cpp/header/cstdint

feel free to close.

@dawa79 dawa79 merged commit d89e27e into morganstanley:main Jan 25, 2024
12 checks passed
@wegank
Copy link

wegank commented Jan 25, 2024

Hi @a-n-n-a-l-e-e , for the moment, hobbes doesn't support llvm12+, at least not officially

In Nixpkgs we do link against LLVM 12. Building the package is another story, and I believe <cstdint> is a missing header for both GCC 13 and Clang 16. So it'll be nice to get this PR in.

@ghost ghost deleted the include-cstdint branch January 25, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants