Miss font loading takes a lot of time

[Hammster]

Hi there,

I had some fun getting mlvwm running on Windows 10 via WSL and vcxsrv, but this issue isn't related to the OS.

Most things worked just as expected, but when I tried setting up the font's for the menu bar etc. I got stuck for a while until it checked for every single encoding (maybe related to #19), gave an error msg, including the acoustic ping. I think this behaviour can be improved, and it would also make sense to add the output to the -debug stream.

This should be the section of code responsible for this.

mlvwm/mlvwm/config.c

Lines 580 to 585 in 7a3daae

	newfont = XCreateFontSet( dpy, fontname, &miss, &n_miss, &def );
	if( n_miss>0 ){
	for( lp=0; lp<n_miss; lp++ )
	DrawErrMsgOnMenu( "Load miss font ", miss[lp] );
	XFreeStringList( miss );
	}

If I find the time, I'm going to do a PR, but it's worth creating an issue for the suggestion anyway.

Cheers

[morgant]

@Hammster Very cool that you got it running under Windows via WSL! Thank you for reporting this issue, it's one that I've just been dealing with because I don't relaunch `mlvwm` all that frequently. Plus, OpenBSD (which I primarily use and develop/test on these days), still had the supported fonts until the 7.0 release. `DrawErrMsgOnMenu()` does sleep for a short period to make it possible to read error messages, so that's causing the delay. I absolutely agree that the output should be included in `stderr` or `stdout` when using `-debug`. I'll dig into this as soon as I can, but PRs are always welcome if you do find the time (no worries if you don't.)

…

On Thu, Mar 17, 2022 at 7:37 AM Hans Koch ***@***.***> wrote: Hi there, I had some fun getting mlvwm running on Windows 10 via WSL and vcxsrv, but this issue isn't related to the OS. Most things worked just as expected, but when I tried setting up the font's for the menu bar etc. I got stuck for a while until it checked for every single encoding, gave an error msg, including the acoustic ping. I think this behaviour can be improved, and it would also make sense to add the output to the -debug stream. This should be the section of code responsible for this. https://github.com/morgant/mlvwm/blob/7a3daaebf4b014d69a2f7a3a340005709e84ac0f/mlvwm/config.c#L580-L585 If I find the time, I'm going to do a PR, but it's worth creating an issue for the suggestion anyway. Cheers — Reply to this email directly, view it on GitHub <#30>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADLXUXFJMTVNUQQKZNQKHLVAMKOXANCNFSM5Q6WE6QQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[morgant]

Again, many thanks to @Hammster for the fix in PR #31, which has now been merged and resolves this issue!