Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Screen support #5

Open
RossComputerGuy opened this issue Jan 29, 2019 · 3 comments
Open

Full Screen support #5

RossComputerGuy opened this issue Jan 29, 2019 · 3 comments

Comments

@RossComputerGuy
Copy link

Full Screening videos in YouTube or full screening anything doesn't work.

@morgant
Copy link
Owner

morgant commented Feb 8, 2020

This might be resolved by adding support for the _NET_WM_STATE_FULLSCREEN atom, but I haven't researched too intensively yet.

@morgant
Copy link
Owner

morgant commented Dec 27, 2020

I'm still learning this codebase, but we might be able to:

  1. Add the Atom to InternUsefulAtoms() in mlvwm/mlvwm.c
  2. Use GetMapStateProp()/SetMapStateProp() from mlvwm/event.c in a new function in mlvwm/functions.c
  3. Call that function from somewhere. Most other state handling is triggered by a button in handle_button_press() in mlvwm/event.c, so I think we'd add some kind of listener to state change.

@morgant
Copy link
Owner

morgant commented Dec 29, 2020

Upon looking into this a bit further, I think we'll actually need to implement more of the Extended Window Manager Hints to be able to enable fullscreen support. OpenBSD's fvwm, which has a compatible license, doesn't seem to support the extended hints, but OpenBSD's cwm does, so that might be a good reference. I'll likely add a separate issue for supporting extended hints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants