You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @moriturus, thanks for open-sourcing this useful project. It works very smoothly(especially with Docker containers :D), but I believe there is a subtle bug:
When a package to be published has a dependency with package field, ktra places it into index wrongly.
Steps to reproduce:
Create a dummy package(say foo)
[package]
name = "foo"version = "0.1.0"edition = "2018"
[dependencies]
hello-world = { version = "*", package = "hello" }
Publish it
Referring Cargo reference, the added index should have dependency with fields "name": "hello-world", "package": "hello", but two fields are interchanged. This causes confusing dependency resolution failure on cargo fetch(no matching package), although cargo search on ktra registry returns the exact package.
To resolve, Into<Dependency> impl of MetadataDependency should swap two fields.
Hi @moriturus, thanks for open-sourcing this useful project. It works very smoothly(especially with Docker containers :D), but I believe there is a subtle bug:
When a package to be published has a dependency with
package
field, ktra places it into index wrongly.Steps to reproduce:
foo
)"name": "hello-world", "package": "hello"
, but two fields are interchanged. This causes confusing dependency resolution failure on cargo fetch(no matching package
), althoughcargo search
on ktra registry returns the exact package.To resolve,
Into<Dependency>
impl ofMetadataDependency
should swap two fields.ktra/src/models.rs
Lines 19 to 34 in 8a14cd2
(possibly fixing) change:
Thanks in advance!
The text was updated successfully, but these errors were encountered: