From 3c5d48cc966da2db85eead458c6b90460f2eae36 Mon Sep 17 00:00:00 2001 From: Jean-Grimal Date: Wed, 18 Oct 2023 15:54:50 +0200 Subject: [PATCH] fix: apply suggestions --- src/ethereum/EthereumPermitBundler.sol | 6 +++--- src/migration/AaveV2MigrationBundler.sol | 2 +- src/migration/AaveV3MigrationBundler.sol | 3 +-- src/migration/AaveV3OptimizerMigrationBundler.sol | 2 +- src/migration/CompoundV2MigrationBundler.sol | 6 +++--- src/migration/CompoundV3MigrationBundler.sol | 1 - 6 files changed, 9 insertions(+), 11 deletions(-) diff --git a/src/ethereum/EthereumPermitBundler.sol b/src/ethereum/EthereumPermitBundler.sol index 470bb5c8..d9e811d9 100644 --- a/src/ethereum/EthereumPermitBundler.sol +++ b/src/ethereum/EthereumPermitBundler.sol @@ -19,9 +19,9 @@ abstract contract EthereumPermitBundler is PermitBundler { /// @param nonce The nonce of the signed message. /// @param expiry The expiry of the signed message. /// @param allowed Whether the initiator gives the bundler infinite Dai approval or not. - /// @param v signature.v - /// @param r signature.r - /// @param s signature.s + /// @param v The `v` component of a signature. + /// @param r The `r` component of a signature. + /// @param s The `s` component of a signature. function permitDai(uint256 nonce, uint256 expiry, bool allowed, uint8 v, bytes32 r, bytes32 s, bool skipRevert) external payable diff --git a/src/migration/AaveV2MigrationBundler.sol b/src/migration/AaveV2MigrationBundler.sol index 901d6d41..2438b28e 100644 --- a/src/migration/AaveV2MigrationBundler.sol +++ b/src/migration/AaveV2MigrationBundler.sol @@ -21,7 +21,7 @@ contract AaveV2MigrationBundler is MigrationBundler { /* CONSTRUCTOR */ - /// @dev Warning: assumes the given addresses are non-zero (they are not expected to be deployment arguments). + /// @dev Warning: assumes the aaveV2Pool address is non-zero (not expected to be deployment arguments). /// @param morpho The Morpho contract Address. /// @param aaveV2Pool The AaveV2 contract address. constructor(address morpho, address aaveV2Pool) MigrationBundler(morpho) { diff --git a/src/migration/AaveV3MigrationBundler.sol b/src/migration/AaveV3MigrationBundler.sol index eee4e9cc..b27e2cb4 100644 --- a/src/migration/AaveV3MigrationBundler.sol +++ b/src/migration/AaveV3MigrationBundler.sol @@ -20,8 +20,7 @@ contract AaveV3MigrationBundler is MigrationBundler { /* CONSTRUCTOR */ - /// @dev Warning: assumes the given addresses are non-zero (they are not expected to be deployment arguments). - /// @dev AaveV3 contract address. + /// @dev Warning: assumes the aaveV3Pool address is non-zero (not expected to be deployment arguments). /// @param morpho The Morpho contract Address. /// @param aaveV3Pool AaveV3 contract address. constructor(address morpho, address aaveV3Pool) MigrationBundler(morpho) { diff --git a/src/migration/AaveV3OptimizerMigrationBundler.sol b/src/migration/AaveV3OptimizerMigrationBundler.sol index fea0fda2..bcf97bfc 100644 --- a/src/migration/AaveV3OptimizerMigrationBundler.sol +++ b/src/migration/AaveV3OptimizerMigrationBundler.sol @@ -21,7 +21,7 @@ contract AaveV3OptimizerMigrationBundler is MigrationBundler { /* CONSTRUCTOR */ - /// @dev Warning: assumes the given addresses are non-zero (they are not expected to be deployment arguments). + /// @dev Warning: assumes the aaveV3Optimizer address is non-zero (not expected to be deployment arguments). /// @param morpho The Morpho contract Address. /// @param aaveV3Optimizer The AaveV3 optmizer contract address. constructor(address morpho, address aaveV3Optimizer) MigrationBundler(morpho) { diff --git a/src/migration/CompoundV2MigrationBundler.sol b/src/migration/CompoundV2MigrationBundler.sol index ede2fa96..ff6d619a 100644 --- a/src/migration/CompoundV2MigrationBundler.sol +++ b/src/migration/CompoundV2MigrationBundler.sol @@ -17,15 +17,15 @@ import {MigrationBundler, ERC20} from "./MigrationBundler.sol"; contract CompoundV2MigrationBundler is WNativeBundler, MigrationBundler { /* IMMUTABLES */ - /// @dev The address of the C_ETH contract. + /// @dev The address of the cETH contract. address public immutable C_ETH; /* CONSTRUCTOR */ - /// @dev Warning: assumes the given addresses are non-zero (they are not expected to be deployment arguments). + /// @dev Warning: assumes the wNative address is non-zero (not expected to be deployment arguments). /// @param morpho The Morpho contract Address. /// @param wNative The address of the wNative token contract. - /// @param cEth The address of the C_ETH contract. + /// @param cEth The address of the cETH contract. constructor(address morpho, address wNative, address cEth) WNativeBundler(wNative) MigrationBundler(morpho) { C_ETH = cEth; } diff --git a/src/migration/CompoundV3MigrationBundler.sol b/src/migration/CompoundV3MigrationBundler.sol index ad0d2b19..6eb6375f 100644 --- a/src/migration/CompoundV3MigrationBundler.sol +++ b/src/migration/CompoundV3MigrationBundler.sol @@ -15,7 +15,6 @@ import {MigrationBundler, ERC20} from "./MigrationBundler.sol"; contract CompoundV3MigrationBundler is MigrationBundler { /* CONSTRUCTOR */ - /// @dev Warning: assumes the given addresses are non-zero (they are not expected to be deployment arguments). /// @param morpho The Morpho contract Address. constructor(address morpho) MigrationBundler(morpho) {}