From afda46d43f0ef192987edbee7d306e449b7cee0c Mon Sep 17 00:00:00 2001 From: Jean-Grimal Date: Tue, 24 Oct 2023 10:52:52 +0200 Subject: [PATCH 1/2] fix: skip-revert-documentation-issue-19 --- src/MorphoBundler.sol | 2 +- src/PermitBundler.sol | 2 +- src/UrdBundler.sol | 2 +- src/ethereum/EthereumPermitBundler.sol | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/MorphoBundler.sol b/src/MorphoBundler.sol index 00aa7bb4..db4767c6 100644 --- a/src/MorphoBundler.sol +++ b/src/MorphoBundler.sol @@ -56,7 +56,7 @@ abstract contract MorphoBundler is BaseBundler, IMorphoBundler { /* ACTIONS */ /// @notice Approves this contract to manage the `authorization.authorizer`'s position via EIP712 `signature`. - /// @dev Pass `skipRevert = true` to avoid reverting the whole bundle in case the signature expired. + /// @dev Pass `skipRevert = true` to avoid reverting the call in case the signature is frontrunned. function morphoSetAuthorizationWithSig( Authorization calldata authorization, Signature calldata signature, diff --git a/src/PermitBundler.sol b/src/PermitBundler.sol index ee916336..5970770a 100644 --- a/src/PermitBundler.sol +++ b/src/PermitBundler.sol @@ -13,7 +13,7 @@ abstract contract PermitBundler is BaseBundler { /// @notice Permits the given `amount` of `asset` from sender to be spent by the bundler via EIP-2612 Permit with /// the given `deadline` & EIP-712 signature's `v`, `r` & `s`. /// @notice Warning: should only be called via the bundler's `multicall` function. - /// @dev Pass `skipRevert == true` to avoid reverting the whole bundle in case the signature expired. + /// @dev Pass `skipRevert = true` to avoid reverting the call in case the signature is frontrunned. function permit(address asset, uint256 amount, uint256 deadline, uint8 v, bytes32 r, bytes32 s, bool skipRevert) external payable diff --git a/src/UrdBundler.sol b/src/UrdBundler.sol index dc8cd165..c036388a 100644 --- a/src/UrdBundler.sol +++ b/src/UrdBundler.sol @@ -15,7 +15,7 @@ import {BaseBundler} from "./BaseBundler.sol"; abstract contract UrdBundler is BaseBundler { /// @notice Claims `amount` of `reward` on behalf of `account` on the given rewards distributor, using `proof`. /// @dev Assumes the given distributor implements IUniversalRewardsDistributor. - /// @dev Pass `skipRevert = true` to avoid reverting the whole bundle in case the proof expired. + /// @dev Pass `skipRevert = true` to avoid reverting the whole bundle in case the proof expired or frontrunned. function urdClaim( address distributor, address account, diff --git a/src/ethereum/EthereumPermitBundler.sol b/src/ethereum/EthereumPermitBundler.sol index 780d88f9..dbb3a9ff 100644 --- a/src/ethereum/EthereumPermitBundler.sol +++ b/src/ethereum/EthereumPermitBundler.sol @@ -15,7 +15,7 @@ abstract contract EthereumPermitBundler is PermitBundler { /// @notice Permits DAI from sender to be spent by the bundler with the given `nonce`, `expiry` & EIP-712 /// signature's `v`, `r` & `s`. /// @notice Warning: should only be called via the bundler's `multicall` function. - /// @dev Pass `skipRevert = true` to avoid reverting the whole bundle in case the signature expired. + /// @dev Pass `skipRevert = true` to avoid reverting the call in case the signature is frontrunned. function permitDai(uint256 nonce, uint256 expiry, bool allowed, uint8 v, bytes32 r, bytes32 s, bool skipRevert) external payable From 6bf2b3f4beb7ba4b32bf7bc32fe736ad2f1fac2c Mon Sep 17 00:00:00 2001 From: Jean-Grimal Date: Tue, 24 Oct 2023 10:55:02 +0200 Subject: [PATCH 2/2] fix: urd natspec --- src/UrdBundler.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/UrdBundler.sol b/src/UrdBundler.sol index c036388a..2f15e955 100644 --- a/src/UrdBundler.sol +++ b/src/UrdBundler.sol @@ -15,7 +15,7 @@ import {BaseBundler} from "./BaseBundler.sol"; abstract contract UrdBundler is BaseBundler { /// @notice Claims `amount` of `reward` on behalf of `account` on the given rewards distributor, using `proof`. /// @dev Assumes the given distributor implements IUniversalRewardsDistributor. - /// @dev Pass `skipRevert = true` to avoid reverting the whole bundle in case the proof expired or frontrunned. + /// @dev Pass `skipRevert = true` to avoid reverting the call in case the proof expired or frontrunned. function urdClaim( address distributor, address account,