Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename repo to morpho-v1-vaults? #253

Open
MerlinEgalite opened this issue Jun 25, 2023 · 3 comments
Open

Rename repo to morpho-v1-vaults? #253

MerlinEgalite opened this issue Jun 25, 2023 · 3 comments
Labels
🧐 question Further information is requested

Comments

@MerlinEgalite
Copy link
Contributor

MerlinEgalite commented Jun 25, 2023

This would avoid confusion with morpho-aave-v3 vault and with other vault that we may build later on

@MerlinEgalite MerlinEgalite added the 🧐 question Further information is requested label Jun 25, 2023
@pakim249CAL
Copy link
Contributor

I'm not a fan of changing a public repo name as I simply believe it is a bad practice that can signal that relying on morpho's repos is unreliable. I think it is enough to update the README to be very specific and clear near the top that the vaults are for morpho-v1 only.

@MerlinEgalite
Copy link
Contributor Author

Well, here I don't think this is a big deal + there are redirections so it will still work + it's a better naming for this repo plus would allow better naming for other repo.

But I agree with your point and don't have a strong opinion on it anyway.

@Rubilmax
Copy link
Contributor

Rubilmax commented Jul 3, 2023

I am ok to change the repo's name as of today. I also understand if we choose to not do so, but then let's name our repository well the first time: tokenized-vaults was obviously a bad name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧐 question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants