-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean function is broken on Windows #78
Comments
Delete operation works fine from Linux Mint 18.1, Node v7.5.0. There is slash displayed instead of Windows backslash, could be related to problem on Windows:
Regarding first mentioned problem it works with
|
With quick and dirty patch in vinyl-ftp/lib/rmdir.js and delete.js I can solve the (second) problem:
|
I confirm the problem on Windows 10 : slash from globs parameter are converted to backslash. The @jry2 patch solve the issue for the moment. |
Yep, I have encountered the same thing. I've been debugging this for over an hour now and it looks like the issue might be in vinyl.
Now is this really a bug on Vinyl's end? I'm guessing yes? Personally I would expect Vinyl to be agnostic of the OS it's running on. I'd want to be able to tell it which style of path I want to use as a config option. For now I don't think there's a "clean" way to fix this bug on Windows within vinyl-ftp itself. I'm currently using a modified if ( method ) {
self[ method ](remote.path, cb );
} else {
cb();
} to if ( method ) {
self[ method ]( self.normalize(remote.path), cb );
} else {
cb();
} Which is just about the tidiest way I can think of to correct this problem. Last bit of info I have on this:
I hope this info helps, please let me know if there's anything I can do to get a fix in place (I use vinyl-ftp for deployment from Windows and really want to see this fixed). Thanks! |
I'm testing vinyl-ftp v0.6.0 on Windows 7 and node v7.2.0.
Following code doesn't work at all:
FTP connection works fine, directories are listed. The first problem is clean function is trying to delete files that should stay (exists in both local and remote directory). Second problem is delete command doesn't work:
The text was updated successfully, but these errors were encountered: