Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] console.error introduced in v0.51.0 #951

Closed
simonnilsson opened this issue May 7, 2024 · 1 comment
Closed

[bug] console.error introduced in v0.51.0 #951

simonnilsson opened this issue May 7, 2024 · 1 comment
Labels

Comments

@simonnilsson
Copy link
Contributor

System Information

  • Aedes: 0.51.0
  • NodeJS: 20.10.0
  • OS: Windows 11
  • Arch: x86_64

Describe the bug
The commit e1ee60c added a console.error log to init function in connect.js, this outputs all errors to console that should ideally only be be returned in the done callback. This change was released in 0.51.0.

To Reproduce
Steps to reproduce the behavior:

  1. Start aedes server
    2a. Connect with protocol 3.1.0 with a client-id longer than 23 characters.
    2b. Connect with protocol 5.0 client.
    2c. Have a keepaliveLimit set and use a longer keepalive in client.

Expected behavior
Done should be called with the error. No log output should be produced.

Additional context
To prevent this I would recommend not allowing console.* during linting.

@robertsLando
Copy link
Member

Fixed by #952

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants