fix test

Signed-off-by: spacewander <[email protected]>

Author: spacewander

api/internal/consumer/consumer.go

@@ -45,9 +45,10 @@ type Consumer struct {
 	FilterConfigs   map[string]*fmModel.ParsedFilterConfig
 
 	// fields that generated from the configuration
-	CanSkipMethod map[string]bool
-	FilterNames   []string
-	InitOnce      sync.Once
+	CanSkipMethod     map[string]bool
+	FilterNames       []string
+	InitOnce          sync.Once
+	CanSkipMethodOnce sync.Once
 }
 
 func (c *Consumer) Unmarshal(s string) error {

api/internal/consumer/consumer_manager.go

@@ -48,6 +48,8 @@ func UpdateConsumers(value *structpb.Struct) {
 			currValue, ok := currIdx[name]
 			if !ok || currValue.generation != v {
 				s := fields["d"].GetStringValue()
+				api.LogInfof("receive consumer configuration: %s", s)
+
 				var c Consumer
 				err := c.Unmarshal(s)
 				if err != nil {

api/internal/consumer/consumer_manager_test.go

@@ -22,6 +22,7 @@ import (
 
 	"mosn.io/htnn/api/pkg/consumer/model"
 	"mosn.io/htnn/api/pkg/plugins"
+	_ "mosn.io/htnn/api/plugins/tests/pkg/envoy" // for log implementation
 )
 
 type consumerTest struct {

api/pkg/filtermanager/filtermanager.go

@@ -601,34 +601,21 @@ func (m *filterManager) DecodeHeaders(headers capi.RequestHeaderMap, endStream b
 
 			if len(c.FilterConfigs) > 0 {
 				c.InitOnce.Do(func() {
-					canSkipMethod := newSkipMethodsMap()
 					names := make([]string, 0, len(c.FilterConfigs))
 					for name, fc := range c.FilterConfigs {
 						names = append(names, name)
 
-						factory := fc.Factory
 						config := fc.ParsedConfig
 						if initer, ok := config.(pkgPlugins.Initer); ok {
 							// For now, we have nothing to provide as config callbacks
 							err := initer.Init(nil)
 							if err != nil {
-								factory = NewInternalErrorFactory(fc.Name, err)
+								fc.Factory = NewInternalErrorFactory(fc.Name, err)
 							}
 						}
-
-						f := factory(config, m.callbacks)
-						for meth := range canSkipMethod {
-							overridden, err := reflectx.IsMethodOverridden(f, meth)
-							if err != nil {
-								api.LogErrorf("failed to check method %s in filter: %v", meth, err)
-								// canSkipMethod[meth] will be false
-							}
-							canSkipMethod[meth] = canSkipMethod[meth] && !overridden
-						}
 					}
 
 					c.FilterNames = names
-					c.CanSkipMethod = canSkipMethod
 				})
 
 				filterWrappers := make([]*model.FilterWrapper, len(c.FilterConfigs))
@@ -640,6 +627,23 @@ func (m *filterManager) DecodeHeaders(headers capi.RequestHeaderMap, endStream b
 					filterWrappers[i] = model.NewFilterWrapper(name, f)
 				}
 
+				c.CanSkipMethodOnce.Do(func() {
+					canSkipMethod := newSkipMethodsMap()
+					for _, fw := range filterWrappers {
+						f := fw.Filter
+						for meth := range canSkipMethod {
+							overridden, err := reflectx.IsMethodOverridden(f, meth)
+							if err != nil {
+								api.LogErrorf("failed to check method %s in filter: %v", meth, err)
+								// canSkipMethod[meth] will be false
+							}
+							canSkipMethod[meth] = canSkipMethod[meth] && !overridden
+						}
+					}
+
+					c.CanSkipMethod = canSkipMethod
+				})
+
 				canSkipMethod := c.CanSkipMethod
 				m.canSkipDecodeData = m.canSkipDecodeData && canSkipMethod["DecodeData"] && canSkipMethod["DecodeRequest"]
 				m.canSkipEncodeHeaders = m.canSkipEncodeData && canSkipMethod["EncodeHeaders"]

api/pkg/plugins/plugins_test.go

@@ -24,7 +24,7 @@ import (
 	"google.golang.org/protobuf/types/known/anypb"
 
 	"mosn.io/htnn/api/pkg/filtermanager/api"
-	_ "mosn.io/htnn/api/plugins/tests/pkg/envoy"
+	_ "mosn.io/htnn/api/plugins/tests/pkg/envoy" // for log implementation
 )
 
 func TestIterateHttpPlugin(t *testing.T) {

api/plugins/tests/integration/config.pb.go

@@ -31,3 +31,7 @@ message BadPluginConfig {
   bool panic_in_parse = 2;
   bool error_in_init = 3;
 }
+
+message ConsumerConfig {
+  string name = 1;
+}