ci: check plugin order #804
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size/L
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
==========================================
- Coverage 87.07% 85.75% -1.33%
==========================================
Files 145 141 -4
Lines 8715 8341 -374
==========================================
- Hits 7589 7153 -436
- Misses 877 933 +56
- Partials 249 255 +6 ☔ View full report in Codecov by Sentry. |
Signed-off-by: spacewander <[email protected]>
spacewander
force-pushed
the
order_plugin
branch
from
4830941
to
b1465a3
Compare
zll600
reviewed
Nov 26, 2024
Comment on lines
18
to
21
| # TODO: This file only show the plugin's registried order. We should consider a fact that | ||
| # some plugins may not be executed in the DecodeHeaders phase. For example, a plugin called when | ||
| # processing response which is registried in an early place is executed after a plugin called | ||
| # when processing request which is registried in a later place. |
There was a problem hiding this comment.
This is the version I modified. WDYT?
This file only shows the plugin's registered order. Some plugins may not be executed in the DecodeHeaders phase.
For example, the plugin called when processing the response but is registered earlier is executed behind the plugin invoked when processing the request but is registered later.
There was a problem hiding this comment.
@zll600
Updated. Thank you!
Co-authored-by: zll600 <[email protected]>
Signed-off-by: spacewander <[email protected]>
Signed-off-by: spacewander <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.