Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backups.proto updated by Signal-Android #4

Closed
lapseofreason opened this issue Oct 29, 2023 · 0 comments · Fixed by #6
Closed

Backups.proto updated by Signal-Android #4

lapseofreason opened this issue Oct 29, 2023 · 0 comments · Fixed by #6

Comments

@lapseofreason
Copy link
Contributor

The file Backups.proto has been updated in the Signal-Android repository in the following commit: signalapp/Signal-Android@c6473ca

Here are the differences to the current version used by signal_for_android_decryption:

diff --git a/Backups.proto b/Backups.proto
index 98e4bdf..83227de 100644
--- a/Backups.proto
+++ b/Backups.proto
@@ -8,8 +8,7 @@ syntax = "proto2";
 
 package signal;
 
-option java_package         = "org.thoughtcrime.securesms.backup";
-option java_outer_classname = "BackupProtos";
+option java_package = "org.thoughtcrime.securesms.backup.proto";
 
 message SqlStatement {
     message SqlParameter {
@@ -55,8 +54,9 @@ message DatabaseVersion {
 }
 
 message Header {
-    optional bytes iv   = 1;
-    optional bytes salt = 2;
+    optional bytes  iv      = 1;
+    optional bytes  salt    = 2;
+    optional uint32 version = 3;
 }
 
 message KeyValue {
@@ -79,4 +79,4 @@ message BackupFrame {
     optional Avatar           avatar     = 7;
     optional Sticker          sticker    = 8;
     optional KeyValue         keyValue   = 9;
-}
+}
\ No newline at end of file

I'm not 100% sure that this means that any changes are needed in signal_for_android_decryption, but I though it might still be useful if I report it anyways.

For signal-backup-decode there is a PR addressing this changes, maybe this can give some pointers on what needs to be adapted: pajowu/signal-backup-decode#60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant