Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Release for bugfix PR #45

Open
Siedlerchr opened this issue May 24, 2022 · 2 comments
Open

New Release for bugfix PR #45

Siedlerchr opened this issue May 24, 2022 · 2 comments

Comments

@Siedlerchr
Copy link
Contributor

Hi,

I just noticed that while you merged my PR #40, there is no new release for my fix. I would appreciate it if you could publish a new version which contains that fix, because today I ran into this again after reinstalling.
@mostafa-mansour1
Copy link
Owner

I think ur code make another issue, can u edit the code, to add more conditions without remove the current conditions

@Siedlerchr
Copy link
Contributor Author

Can you please explain where you encountered an issue? In your condition you also just intialized the URL object. And that failed because you took the wrong url variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Siedlerchr @mostafa-mansour1