Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The problem of runtime #20

Open
Hill-Jiang opened this issue Apr 27, 2018 · 7 comments
Open

The problem of runtime #20

Hill-Jiang opened this issue Apr 27, 2018 · 7 comments

Comments

@Hill-Jiang
Copy link

@movehand
Hello, can I ask you a question about the running speed of the program?
GOOGLE says that the RAISR runtime is about 10^-2 to 10^-1 seconds.
But I test it and the actual running time of a 512*512 medium sized image on the i7 processor was tens of seconds.
Why the difference between the two running time is so huge?

@movehand
Copy link
Owner

I think it's simply the method of the actual implementation. This project is simply a rough guide of how RAISR works. So, without unrolling loop, parallelizing, etc. PyCUDA may be a nice option to speed things up!

@BlauerHunger
Copy link

It would probably help to get rid of the numpy arrays. Then it would be easy to parallelize the preprocessing on the cpu using multiprocessing.Pool.

@bluewidy
Copy link

bluewidy commented Jul 7, 2018

@BlauerHunger
How can I do that? Can you show me the parallel processing source code file?

@BlauerHunger
Copy link

Multiprocessing is explained here: https://docs.python.org/3/library/multiprocessing.html
You can run a function over every element of a list in n processes running in parallel using Pool(n).map(function, list). Since the globals are copies and not shared, sharing data (such as the q and v) must be done either using returns (this might even be possible using the numpy arrays) or this way: https://docs.python.org/3/library/multiprocessing.html#sharing-state-between-processes

Additional efficiency could be gained by adding type information and compiling the project with cython.

@excllent123
Copy link

@Shuaibishay Have you compared the result with A+? The result is bad compared with A+.and train takes a week in i7-8700 under div2k dateset.

@hezc13
Copy link

hezc13 commented Jul 26, 2018

@excllent123 Could you offer me your A+ code?I want to compare the results between the two algorithms.You can touch me with [email protected]

@jtoy
Copy link

jtoy commented Oct 19, 2018

any plans to get this working?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants