Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all breakpoints #26

Open
adamf321 opened this issue Mar 25, 2016 · 0 comments
Open

Include all breakpoints #26

adamf321 opened this issue Mar 25, 2016 · 0 comments
Assignees
Labels

Comments

@adamf321
Copy link

Would it make sense to include a complete set by default in _media.scss?

eg this is what we have for nowthis:

/* sizes */
$_mobile_xs_width: 319px;

$_mobile_s_width: 320px;
$_mobile_s_height: 568px;

$_mobile_m_width: 375px;

$_mobile_l_width: 480px;

$_tablet_width: 769px;

$_desktop_width: 960px;


/* media queries */
$mobile_xs: new-breakpoint(max-width $_mobile_xs_width 12);

$mobile_s: new-breakpoint(min-width $_mobile_s_width 12);
$mobile_s-portrait: new-breakpoint(min-width $_mobile_s_width orientation portrait 2);
$mobile_s-landscape: new-breakpoint(min-width $_mobile_s_height orientation landscape 2);

$mobile_m: new-breakpoint(min-width $_mobile_m_width 12);
$mobile_m-portrait: new-breakpoint(min-width $_mobile_m_width orientation portrait 2);

$mobile_l: new-breakpoint(min-width $_mobile_l_width 12);

$tablet: new-breakpoint(min-width $_tablet_width 12);
$tablet-portrait: new-breakpoint(min-width $_tablet_width orientation portrait 2);

$desktop: new-breakpoint(min-width $_desktop_width 12);

@nacho87 nacho87 self-assigned this Apr 7, 2016
nacho87 added a commit that referenced this issue Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants