Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Searching..." overlay does not automatically disappear once the search is complete #208

Open
kevinaboos opened this issue Aug 7, 2024 · 6 comments
Labels
area: frontend blocked by makepad bug Something isn't working good first issue Good for newcomers

Comments

@kevinaboos
Copy link
Contributor

After searching for a term on the "Discover" screen, the Searching... animation will be shown forever until the user scrolls on the screen.

See screenshot below, which will remain on the screen indefinitely until the user scrolls up or down.

I assume the problem is related to something like a forgotten call to redraw() after the search results have been fully returned.

image

@kevinaboos kevinaboos added bug Something isn't working good first issue Good for newcomers labels Aug 7, 2024
@CouldBeFree
Copy link

I want to resolve this issue, but I face some problems running this project.
I have got this error: failed to run custom build command for `wasmedge-sys v0.19.2
I have tried to add this library to the cargo.toml file, but with no success

[dependencies]
moxin-protocol = { path = "moxin-protocol" }
moxin-backend = { path = "moxin-backend" }
moxin-fake-backend = { path = "moxin-fake-backend" }
wasmedge-sys = {version = "0.19.2"} -> New line

@kevinaboos
Copy link
Contributor Author

Hi @CouldBeFree, thanks for looking into this! The error you're getting means that you haven't installed WasmEdge, or the build system cannot find your installation of WasmEdge.

Have you followed the build & setup instructions in the readme? https://github.com/moxin-org/moxin/tree/dev?tab=readme-ov-file#building-and-running
If you have and it's not working for you, please let us know:

  • which OS you're on
  • dump out a tree view of the WasmEdge directory
  • dump out the values of all environment variables

Also, make sure to use the latest dev branch, main is a bit old.

@CouldBeFree
Copy link

CouldBeFree commented Aug 10, 2024

@kevinaboos thank you for your support. I can't reproduce this bug, searching disappeared as expected

Screen.Recording.compressed.mp4

@Guocork
Copy link
Collaborator

Guocork commented Aug 12, 2024

I am using Ubuntu, and initially, I also encountered this problem. When I was fixing it, I adjusted the order of the logic code which resolved the issue, but the logic became incorrect. I added a redraw() function, which solved the problem, but the searching disappeared very slowly.
#211.

@joulei joulei mentioned this issue Aug 15, 2024
@joulei
Copy link
Collaborator

joulei commented Aug 15, 2024

We'll review this behavior in Makepad:
#211 (comment)

@kevinaboos
Copy link
Contributor Author

@kevinaboos thank you for your support. I can't reproduce this bug, searching disappeared as expected

Screen.Recording.compressed.mp4

yep, it appears to be working on macOS but not on other platforms, indicating a bug in the UI framework itself. Thanks for helping us test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend blocked by makepad bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants