Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement "jump to bottom" button using PortalList::is_at_end() #222

Open
jmbejar opened this issue Aug 19, 2024 · 1 comment
Open

Reimplement "jump to bottom" button using PortalList::is_at_end() #222

jmbejar opened this issue Aug 19, 2024 · 1 comment

Comments

@jmbejar
Copy link
Collaborator

jmbejar commented Aug 19, 2024

The "Jump to bottom" button visibility in the chat widget is currently controlled by having an extra empty element in the chat conversation list. When the associated PortalList renders this element it means we are "at the bottom of the list", so the button should be hidden.

In Makepad, a new PortalList::is_at_end() function was recently added. It theory, it should provide the bit of information we need here: if the list is scrolled at the end or not. The task is to replace our previous approach using this cleaner solution.

Note: We need first to bump to the latest Makepad version, which is an ongoing effort now. I will update this issue whenever is ready.

@kevinaboos
Copy link
Contributor

apparently is_at_end() is not flawless yet, but it does appear to work better than prior attempts.

See our discussion here: project-robius/robrix#91 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants