Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Tech 1337" name is shown for all users in sso prod #258

Open
viorelaioia-zz opened this issue Mar 21, 2018 · 7 comments
Open

"Tech 1337" name is shown for all users in sso prod #258

viorelaioia-zz opened this issue Mar 21, 2018 · 7 comments
Assignees
Labels

Comments

@viorelaioia-zz
Copy link

viorelaioia-zz commented Mar 21, 2018

STR:

  1. Login to sso.mozilla.com
  2. Click the avatar in the top right corner

Expected:
User's name from mozillians is shown.

Actual:
"Tech 1337" name is shown.

user name in sso

@andrewkrug andrewkrug self-assigned this Mar 21, 2018
@andrewkrug
Copy link
Contributor

@viorelaioia good catch.

@andrewkrug
Copy link
Contributor

Fixed in prod.

@viorelaioia-zz
Copy link
Author

Now user_id is displayed instead of first name, even though I have a value set for first name in mozillians.org. @andrewkrug , can we change this field to show first name?
screen shot 2018-03-22 at 08 03 47

@viorelaioia-zz
Copy link
Author

@andrewkrug , just saw the thread where you said we cannot use firstName/lastName, due to switching to OIDC conformant. Can we at least show username, instead of user_id?

@andrewkrug
Copy link
Contributor

andrewkrug commented Mar 22, 2018

We only have what's available in the id_token. Which is incredibly limited. Once the LDAP publisher is in place and the data is guaranteed it's kind of a different story.

For now it will be the lowest common denominator.

@ioana-chiorean
Copy link

ioana-chiorean commented Mar 23, 2018

Feeling like I have many personalities lately.. but NULL was not one of them on my list :D
Note: I do not have a mozillians.org account with my mozilla LDAP ( it is under an old community mail)

screenshot from 2018-03-23 10-01-27

@viorelaioia-zz
Copy link
Author

viorelaioia-zz commented Mar 28, 2018

This is still not fixed and it behaves differently for LDAP than for github.
Tested in sso.allizom.org, which uses auth0 prod.
LDAP ([email protected]) first name shows NULL. (No user using that email in mozillians prod)

null

Github ([email protected]) first name shows empty string, but no generic mozillians avatar. (No user using that email in mozillians prod)

github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants