Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Docker builder image for metrics CLI 🐳 #27

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Upgrade Docker builder image for metrics CLI 🐳 #27

merged 1 commit into from
Nov 18, 2024

Conversation

hackebrot
Copy link
Member

Using the same Docker build image as for #26.

@hackebrot hackebrot added the dependencies Pull requests that update a dependency file label Nov 18, 2024
@hackebrot hackebrot requested a review from a team November 18, 2024 17:14
grahamalama
grahamalama approved these changes Nov 18, 2024
View reviewed changes
metrics/Dockerfile
@@ -1,4 +1,4 @@
FROM golang:1.22 AS builder
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a follow-on, it might be nice to set up Dependabot in this repo to automate PRs like these

@hackebrot
Copy link
Member Author

Thanks for the review, @grahamalama! 🚀

@hackebrot hackebrot added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit 7341791 Nov 18, 2024
3 checks passed
@hackebrot hackebrot deleted the upgrade-metrics-docker-builder-image branch November 18, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamalama grahamalama grahamalama approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hackebrot @grahamalama