Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output a fingerprinting list #110

Open
garvankeeley opened this issue Dec 9, 2019 · 7 comments
Open

Output a fingerprinting list #110

garvankeeley opened this issue Dec 9, 2019 · 7 comments

Comments

@garvankeeley
Copy link

The fingerprinting list is an intersection of the shavar fingerprinting list and some other list (I am not sure which one).
For iOS (and possibly other consumers), the fingerprinting list is needed as a dedicated list. Ideally this would be a simple JSON array of domains to simplify consumer parsing.

@svensevenslow
Copy link

Hi! I'd like to work on this issue. Could you please explain in a little bit more detail about what needs to be done?

@svensevenslow
Copy link

svensevenslow commented Mar 19, 2020

@skim1102 Hi! I'd like to work on this issue. Could you please explain in a little bit more detail about what needs to be done? As far as I understood I need to make/add changes to sample_shavar_list_creation.ini file and maybe the disconnect_mapping.json file?

@garvankeeley
Copy link
Author

@say-yawn
Copy link
Contributor

@svensevenslow, yes you can work on this one. As @garvankeeley pointed out, we need to generate the base-fingerprinting-track.json and create a PR on the shavar-prod-lists when changes happen on any of the following categories: Advertising, Analytics, Social, Content, or Fingerprinting as specified in the configuration for generating the base-fingerprinting-track-digest256 here. No change is needed on the diconnect_mappaing.json and the .ini files but you may want to generate the base-fingerprinting-track.json file when the base-fingerprinting-track-digest256 is generated and use the GitHub API to create a PR to shavar-prod-lists when the files are checked and need to be published in publish2cloud.py.

To create a PR, I believe a Mozilla GitHub account credential is needed. We can get this information when the PR is ready to be merged. For now, please test using your cloned copy of shavar-list-creation and shavar-prod-lists.

@say-yawn say-yawn reopened this Mar 23, 2020
@say-yawn
Copy link
Contributor

@svensevenslow, please note that the branches on shavar-prod-lists are versioned. Meaning base-fingerprinting-track.json should be generated using values in the respective versioned branch in shavar-prod-lists repo AND the JSON file should be uploaded to the respective versioned branches.

@svensevenslow
Copy link

Thank you for the detailed explanation, I'll get back to you if I have any queries while working on it.

@svensevenslow
Copy link

Hi @skim1102 ! I've opened a PR for this issue, could you please have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants