Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obsolete domains on remapping list #82

Open
arthur-mozilla opened this issue May 15, 2019 · 3 comments
Open

obsolete domains on remapping list #82

arthur-mozilla opened this issue May 15, 2019 · 3 comments

Comments

@arthur-mozilla
Copy link

Two domains are on the remapping list but not on the blacklist:

  • googletagmanager.com
  • backtype.com
@groovecoder
Copy link
Contributor

Thanks for filing. I have to think if it's worth fixing these on their own, or waiting until we have another list update planned. (Any time we create new lists we cause a big spike of downloads across all Firefox users [and from our servers].)

@englehardt - best I can tell, the _parse_blocklist function in DisconnectParser.py will simply never try to re-map these domains, now that they are out of the blocklist?

If so, it seems like we can change/fix this, and there will be no effect on the generated list.

@englehardt
Copy link
Contributor

@groovecoder that's correct. Removing these two domains should have no impact on the generated lists.

@boolean5
Copy link
Contributor

boolean5 commented Apr 1, 2020

I think this can be closed now, as the disconnect_mapping.json file was removed in #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants