Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare entity list entries against the public suffix list. #91

Open
englehardt opened this issue Sep 11, 2019 · 0 comments
Open

Compare entity list entries against the public suffix list. #91

englehardt opened this issue Sep 11, 2019 · 0 comments

Comments

@englehardt
Copy link
Contributor

When we consume the entity list, we generate safebrowsing hashes of the form http://<property_origin>/?resource=<resource_origin>. We do so by directly passing the origins given in the Disconnect entity list.

When these origins are checked in Firefox, we grab the hostname of the top-level page and the base domain of the third-party resource (i.e., the eTLD+1) and perform a lookup through safebrowsing for this fake URI. Thus, if the Disconnect list contains anything other than the eTLD+1 for the resource_origin, the safebrowsing lookup will fail and we'll fail to whitelist those resources.

The list creation script should ensure that all resource origins are either the eTLD or the eTLD+1 by throwing an error when the resource_origin does not match either of these. An example of the latter is fbsbx.com -- the PSL contains apps.fbsbx.com.

Note that we've chosen to allow resource origins that match an eTLD or an eTLD+1 to give us the ability to fix to the type of breakage documented in Bug 1580416. We should carefully review any resource entry that is an eTLD rather than an eTLD+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant