Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please specify a license for this repo #117

Open
54696d21 opened this issue Feb 13, 2021 · 12 comments
Open

Please specify a license for this repo #117

54696d21 opened this issue Feb 13, 2021 · 12 comments

Comments

@54696d21
Copy link

No description provided.

@lissyx
Copy link
Contributor

lissyx commented Feb 13, 2021

Please explain why, and also understand it's a repo containing code from multiple authors ...

@54696d21
Copy link
Author

I wrote something small based on the vad_transcriber and want to know if I can publish it and if so under what license

@lissyx
Copy link
Contributor

lissyx commented Feb 13, 2021

@54696d21 You should ping the person who wrote it?

@lissyx
Copy link
Contributor

lissyx commented Feb 13, 2021

@bak What is your license for this code ?

@lissyx
Copy link
Contributor

lissyx commented Feb 13, 2021

@54696d21 If you are willing to help us and reach out to authors to clarify the license were needed, feel free: at first, since it was hosted in the main repo, I think people were okay and it should fall under the MPL, but clarification can be welcome ?

@lissyx
Copy link
Contributor

lissyx commented Feb 13, 2021

FTR, latest examples on the old repo before moving to this one: https://github.com/mozilla/DeepSpeech/tree/v0.6.0/examples

@54696d21
Copy link
Author

Ok, if the code I took originally appeared in that repo which is under MPL then I should be ok. Thank you very much :)

@reuben
Copy link
Contributor

reuben commented Feb 14, 2021

Ouch. This was a stupid oversight when moving the examples from the main repo to here :(

The intention has always been to keep MPL-2.0 like the main repo, but now we have to reach out to people who contributed in the mean time to confirm they're OK with the license. I'll do that in this issue.

@Andrew-Chen-Wang
Copy link

@reuben If the original repo's code was simply migrated without modification, then I don't see a problem with slapping the MPL-2.0 license on to this repository? I'm no lawyer, this shouldn't be legal advice, Mozilla should have more than enough lawyers, and I actually haven't fully read the MPL-2.0 license before, but assuming it's similar to the other modern open source license, it's fair game to modify the code however you wish without notifying anyone and thus the code should be compatible with any new license it's fallen under, even if it's the same from the original repo... at least I think.

@reuben
Copy link
Contributor

reuben commented Mar 29, 2021

@reuben If the original repo's code was simply migrated without modification, then I don't see a problem with slapping the MPL-2.0 license on to this repository?

Correct. Unmodified code from the previous repo is still MPL-2.0. The author consent is needed for modifications contributed directly here, after the repo move.

@Andrew-Chen-Wang
Copy link

Ah I didn't realize there were some minor contributions made here as well. Duly noted!

@chriswells0
Copy link

This is sort of a big deal, right? The more changes are merged, the harder it will get for people.

I'm in the same spot: I'd like to share some small changes to mic_vad_streaming.py that adds basic recognition of a few voice commands while transcribing speech to text. It looks like that file would fall under the MPL, but I'm also not a lawyer and don't feel comfortable making a guess at whether it's legal to share. Maybe I could refactor to have a script that calls mic_vad_streaming.py instead...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants