Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_execute_browser_action in manifest V3 #4681

Open
regseb opened this issue Jan 22, 2023 · 1 comment
Open

_execute_browser_action in manifest V3 #4681

regseb opened this issue Jan 22, 2023 · 1 comment
Labels
component:MV3 Issues related to Manifest Version 3 priority:p3

Comments

@regseb
Copy link
Contributor

regseb commented Jan 22, 2023

Describe the problem and steps to reproduce it:

addons-linter doesn't report any warning for the /commands/_execute_browser_action property for a manifest V3.

{
    "manifest_version": 3,
    "...": "...",

    "action": {
        "...": "..."
    },

    "commands": {
        "_execute_browser_action": {
            "suggested_key": {
                "default": "Alt+K"
            }
        }
    }
}

What happened?

No warnings are reported.

What did you expect to happen?

addons-linter reports a warning as for the browser_action property.

Code Message Description File Line Column
MANIFEST_FIELD_UNSUPPORTED "/commands/_execute_browser_action" is in a format not supported in manifest versions > 2. "/commands/_execute_browser_action" is in a format not supported in manifest versions > 2. manifest.json

Anything else we should know?

Maybe same problem with /commands/_execute_page_action property.

┆Issue is synchronized with this Jira Task

@Rob--W
Copy link
Member

Rob--W commented Jan 23, 2023

Warning about _execute_browser_action makes sense, as it has been replaced with _execute_action in MV3.

_execute_page_action is still supported in Firefox's MV3 though.

@Rob--W Rob--W added priority:p3 component:MV3 Issues related to Manifest Version 3 labels Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:MV3 Issues related to Manifest Version 3 priority:p3
Projects
None yet
Development

No branches or pull requests

2 participants