Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow confirmation of auto-approval of deleted signed add-on versions #1948

Open
abhn opened this issue Jul 27, 2023 · 9 comments · May be fixed by mozilla/addons-server#22942
Open

Allow confirmation of auto-approval of deleted signed add-on versions #1948

abhn opened this issue Jul 27, 2023 · 9 comments · May be fixed by mozilla/addons-server#22942

Comments

@abhn
Copy link

abhn commented Jul 27, 2023

Describe the problem and steps to reproduce it:

For an add-on version that was

  • Signed (auto-approved)
  • Deleted by the developer
  • Needs to be reviewed

There's no good way to mark it as reviewed (The reviewer can add a comment, but that isn't ideal as then we need separate logic to count this add-on's review)

What did you expect to happen?

  • The "Confirm auto-approval" button works for add-on versions which were signed by AMO, even if they are deleted.
  • A reviewer is able to mark an auto-approved version of an add-on as confirmed even if it is deleted

┆Issue is synchronized with this Jira Task

@abhn abhn changed the title Allow confirmation of auto-approval of deleted add-on versions Allow confirmation of auto-approval of deleted signed add-on versions Jul 27, 2023
@eviljeff
Copy link
Member

@abhn can you clarify which action you're referring to - is it "Confirm Approval", which is available for listed, so would apply to a single "latest" version in the channel, and that version chosen as the latest wouldn't be deleted unless the user had REVIEWS_ADMIN permission (do you have that permission on prod?).
Or "Confirm Multiple Versions", which is for unlisted?

It does seem like the action is written with deleted versions in mind (there's a comment about them).

@KevinMind
Copy link
Contributor

@KevinMind KevinMind transferred this issue from mozilla/addons-server May 3, 2024
@KevinMind KevinMind added repository:addons-server Issue relating to addons-server migration:2024 labels May 3, 2024
@wagnerand
Copy link
Member

@abhn is this still an issue? If so, can you provide some more context and reply to @eviljeff's questions?

@abhn
Copy link
Author

abhn commented Aug 29, 2024

@wagnerand haven't had this case in a while, but if nothing's changed, the next time the situation in OP comes up, we might hit this.

@eviljeff (apologies, looks like I missed your message for a year 3:) I think it should be the "Confirm Multiple Versions" action that should include the deleted versions.

The rationale to this is that if we can set "Needs Human Review" on a deleted version (and reviewers have to review one such version), then we should be able to follow standard processes around a signed version review even if it was deleted. Does that make sense, or am I missing out on something here?

@eviljeff
Copy link
Member

Assuming past me was correct when he said "action is written with deleted versions in mind (there's a comment about them)." then it's a bug that deleted (unlisted) versions can't be confirmed.

@abhn
Copy link
Author

abhn commented Aug 29, 2024

In that case, does this issue (and the included STR) suffice to track the bug? Or would you like specific examples where this is happening (I don't have one handy or in recent memory, but if you need additional details, I can try to gather).

@eviljeff
Copy link
Member

If it's happening with every deleted version then the STR is sufficient... if it's not happening with every deleted version, but under some other circumstances, then we'll need more details and/or some links to examples to investigate.

@eviljeff
Copy link
Member

(I'm kinda assuming it's every deleted version, but if you have evidence/recollection otherwise, that's good to know)

@abhn
Copy link
Author

abhn commented Aug 30, 2024

kinda assuming it's every deleted version

Yes, I checked two more cases today (one of which is my own add-on) and it held true everywhere. "Confirm multiple versions" don't show deleted versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants