-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow confirmation of auto-approval of deleted signed add-on versions #1948
Comments
@abhn can you clarify which action you're referring to - is it "Confirm Approval", which is available for listed, so would apply to a single "latest" version in the channel, and that version chosen as the latest wouldn't be deleted unless the user had It does seem like the action is written with deleted versions in mind (there's a comment about them). |
Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDSRV-465 |
@wagnerand haven't had this case in a while, but if nothing's changed, the next time the situation in OP comes up, we might hit this. @eviljeff (apologies, looks like I missed your message for a year 3:) I think it should be the "Confirm Multiple Versions" action that should include the deleted versions. The rationale to this is that if we can set "Needs Human Review" on a deleted version (and reviewers have to review one such version), then we should be able to follow standard processes around a signed version review even if it was deleted. Does that make sense, or am I missing out on something here? |
Assuming past me was correct when he said "action is written with deleted versions in mind (there's a comment about them)." then it's a bug that deleted (unlisted) versions can't be confirmed. |
In that case, does this issue (and the included STR) suffice to track the bug? Or would you like specific examples where this is happening (I don't have one handy or in recent memory, but if you need additional details, I can try to gather). |
If it's happening with every deleted version then the STR is sufficient... if it's not happening with every deleted version, but under some other circumstances, then we'll need more details and/or some links to examples to investigate. |
(I'm kinda assuming it's every deleted version, but if you have evidence/recollection otherwise, that's good to know) |
Yes, I checked two more cases today (one of which is my own add-on) and it held true everywhere. "Confirm multiple versions" don't show deleted versions. |
Describe the problem and steps to reproduce it:
For an add-on version that was
There's no good way to mark it as reviewed (The reviewer can add a comment, but that isn't ideal as then we need separate logic to count this add-on's review)
What did you expect to happen?
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: