Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Don't flag add-ons for growth threshold if hotness is negative #15262

Open
1 task
abhn opened this issue Dec 26, 2024 · 2 comments
Open
1 task

[Task] Don't flag add-ons for growth threshold if hotness is negative #15262

abhn opened this issue Dec 26, 2024 · 2 comments
Labels
needs:info repository:addons-frontend Issue relating to addons-frontend repository:addons-server Issue relating to addons-server

Comments

@abhn
Copy link

abhn commented Dec 26, 2024

Description

As an operations engineer, I'd like to not flag add-ons for growth threshold if the add-on's growth is negative even if the negative growth value is higher than the (sub-tier average growth + threshold) where

  • add-on's growth - period over period change of add-on's ADU count
  • sub-tier average growth - average of all add-ons' growth in a particular usage (sub)tier
  • threshold - the value above the sub-tier's average growth, growing above which will flag the add-on for manual review

By way of an example

  • If a subtier has 5 add-ons with the average growth as follows: -0.10, -0.23, -0.90, -0.32, 0.56
  • the average growth of that subtier is SUM(-0.10, -0.23, -0.90, -0.32, 0.56), or -0.99 / 5 or -0.2
  • the growth threshold is set 0.05

Currently, the add-ons with the following growth will be flagged: -0.10 and 0.56 (subtier average growth + threshold, or -0.2 + 0.05, or -0.15)

We'd like for add-ons with negative growth to not be flagged for growth here, that is, add-on with growth -0.10 to not be flagged, but 0.56 to be.

Acceptance Criteria

Milestones/checkpoints

Preview Give feedback

Checks

  • If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task

@abhn abhn added needs:info repository:addons-server Issue relating to addons-server repository:addons-frontend Issue relating to addons-frontend labels Dec 26, 2024
@KevinMind
Copy link
Contributor

@abhn Can you clarify if this is ready to triage.

@abhn abhn changed the title [Task][Definition WIP]: Don't flag add-ons for growth threshold if hotness is negative [Task] Don't flag add-ons for growth threshold if hotness is negative Jan 14, 2025
@abhn
Copy link
Author

abhn commented Jan 14, 2025

@KevinMind now it is. Thanks for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:info repository:addons-frontend Issue relating to addons-frontend repository:addons-server Issue relating to addons-server
Projects
None yet
Development

No branches or pull requests

2 participants