Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh: Add new font to all pages #15088

Closed
Tracked by #14826
stephaniehobson opened this issue Sep 6, 2024 · 3 comments
Closed
Tracked by #14826

Refresh: Add new font to all pages #15088

stephaniehobson opened this issue Sep 6, 2024 · 3 comments
Assignees
Labels
P1 First level priority - Must have Refresh 🦖 Work related to the 2024 site refresh

Comments

@stephaniehobson
Copy link
Contributor

stephaniehobson commented Sep 6, 2024

  • Over-ride Protocol themes to use the new font on all pages** of the website
  • Behind a switch prefixed with M24
  • Non-Latin languages should still use their fallback fonts

** Dan needs to review the Firefox pages

@stephaniehobson stephaniehobson changed the title Add new font to all non-Firefox pages Refresh: Add new font to all non-Firefox pages Sep 6, 2024
@stephaniehobson stephaniehobson changed the title Refresh: Add new font to all non-Firefox pages Refresh: Add new font to all pages Sep 6, 2024
@stephaniehobson stephaniehobson added Refresh 🦖 Work related to the 2024 site refresh P1 First level priority - Must have labels Sep 6, 2024
@wen-2018 wen-2018 mentioned this issue Sep 11, 2024
11 tasks
@alexgibson
Copy link
Member

alexgibson commented Sep 11, 2024

Some additional things that came up in code review to figure out:

  • When the new nav / footer are displayed on OLD pages, what font should they use? Loading both font families might be less jarring in terms of differences from one page to the next, but might be pretty heavy performance wise.
  • All Mozilla themed pages will use the new font, but Firefox themed pages will not yet. How should the nav / footer font look on this scenario e.g. on /firefox/new/?

@alexgibson
Copy link
Member

See also #15120

@stephaniehobson
Copy link
Contributor Author

stephaniehobson commented Sep 12, 2024

When the new nav / footer are displayed on OLD pages, what font should they use? Loading both font families might be less jarring in terms of differences from one page to the next, but might be pretty heavy performance wise.

The new header and footer should always display with the new fonts -- we don't want them changing from page to page.

All Mozilla themed pages will use the new font, but Firefox themed pages will not yet. How should the nav / footer font look on this scenario e.g. on /firefox/new/?

We're going to put the new fonts on the FIrefox pages and see how they look. Hopefully this works and the performance implications are minimal 🤞 If it's awful maybe there's still a possibility of swapping the font on the body copy even if we keep the headlines in Metropolis to at least lighten the perf implications.

craigcook added a commit that referenced this issue Sep 14, 2024
craigcook added a commit that referenced this issue Sep 16, 2024
craigcook added a commit that referenced this issue Sep 16, 2024
craigcook added a commit that referenced this issue Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 First level priority - Must have Refresh 🦖 Work related to the 2024 site refresh
Projects
Status: Done
Development

No branches or pull requests

3 participants