Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refresh] Navigation close button is half way off screen when focus is received #15156

Closed
alexgibson opened this issue Sep 16, 2024 · 1 comment
Assignees
Labels
Bug 🐛 Something's not working the way it should

Comments

@alexgibson
Copy link
Member

Description

On desktop, when trying to use the new navigation using keyboard, the menu close button is not displayed correctly.

Steps to reproduce

  1. On desktop open https://www-dev.allizom.org/en-US/.
  2. Using keyboard, tab through to "Firefox Browsers" in the navigation menu and press enter.
  3. Press tab again.

Expected result

Focus should move to the menu close button, which should be clearly presented.

Actual result

The close button is floated half way off screen.

image

It should be placed within the menu where it is clearly visible. Having it displayed always would also be beneficial for visitors on touch devices.

Environment

Firefox
macOS

@alexgibson alexgibson added the Bug 🐛 Something's not working the way it should label Sep 16, 2024
@wen-2018 wen-2018 self-assigned this Sep 16, 2024
@stephaniehobson
Copy link
Contributor

Design suggestion:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 Something's not working the way it should
Projects
Status: In Progress
Development

No branches or pull requests

3 participants