Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[M24] New base bundle doesn't include rebrand logic for old footer #15206

Closed
janbrasna opened this issue Sep 23, 2024 · 2 comments · Fixed by #15200
Closed

[M24] New base bundle doesn't include rebrand logic for old footer #15206

janbrasna opened this issue Sep 23, 2024 · 2 comments · Fixed by #15200
Labels
Bug 🐛 Something's not working the way it should

Comments

@janbrasna
Copy link
Contributor

Description

Even after switching to the 2024 base stylesheet, the old nav & footer is still being used (basically because it's an independent switch, but even that shows it only for default locale or progressively only to locales based on its ftl activation threshold / translation completion), so to avoid unexpected changes between various switch combinations being flipped, even the new base stylesheet should support both old and new brand based on its switch/class.

Steps to reproduce

With all refresh switches flipped, visit some non-en page, e.g. http://localhost:8000/cy/ or http://localhost:8000/sco/?xv=legacy — these will display the og elements that will continue to be served for parts of the site.

Expected result

New logo in both old nav & footer.

Actual result

Screenshot 2024-09-22 at 18 53 32

Header links proper img based on the switch. Footer only adds class based on the switch, so the declaration for .m24-logo needs to set the correct asset explicitly.

Environment

All the switches enabled.

@janbrasna janbrasna added the Bug 🐛 Something's not working the way it should label Sep 23, 2024
@alexgibson
Copy link
Member

See also: #15120

@janbrasna
Copy link
Contributor Author

janbrasna commented Sep 23, 2024

@alexgibson I believe that task was actually started with #15144 (base-protocol-2024.scss) — so #15200 only follows up (monkey-patching the same temp overrides supporting the m24-logo switch in all the bundle variants:/…) — feel free to supersede it once there's a better fix.

@alexgibson alexgibson moved this to Dev Ready in Moz.org Refresh Sep 25, 2024
@github-project-automation github-project-automation bot moved this from Dev Ready to In Progress in Moz.org Refresh Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 Something's not working the way it should
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants