Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ir module public #1009

Open
LucaCiucci opened this issue Oct 9, 2024 · 2 comments · May be fixed by #1011
Open

Make ir module public #1009

LucaCiucci opened this issue Oct 9, 2024 · 2 comments · May be fixed by #1011

Comments

@LucaCiucci
Copy link

LucaCiucci commented Oct 9, 2024 •
edited
Loading

This would allow users to easily customize the bindings by inspecting the bindings items.

Is there any particular reason why most of the modules are private?
If the concern is exposing too much complexity, we could just make ir and other modules public with a feature flag, such as "internals".

AFAIK the only walk-around at the moment is to use a modified version of this crate.
@zhp46
Copy link

zhp46 commented Oct 11, 2024

I think this feature would be nice too, currently I am also using a modified version of this crate to do this. The IR is very useful when using the generated C objects in bindings for other languages.

@heesooy heesooy linked a pull request Oct 11, 2024 that will close this issue
Open
@heesooy
Copy link

heesooy commented Oct 17, 2024

@emilio are you the right person to tag here? I put up a PR to expose the ir module under a feature flag. I also had a similar use case where I'm using the ir and currently having to fork. Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add unstable_ir feature flag that makes the ir pub heesooy/cbindgen
3 participants
@heesooy @LucaCiucci @zhp46