Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change import path to django_csp - breaking change #221

Closed
robhudson opened this issue May 31, 2024 · 1 comment
Closed

Change import path to django_csp - breaking change #221

robhudson opened this issue May 31, 2024 · 1 comment

Comments

@robhudson
Copy link
Member

In pull request #219, I’ve refactored the settings configuration to support both the enforced CSP header and the report-only CSP header. Please note, this is a backwards incompatible change.

To minimize disruptions over multiple releases, I propose making multiple backwards incompatible changes at once. Specifically, I suggest changing the import path from csp to django_csp, aligning with common practices for Django apps.

I’m opening this issue for discussion. Please share any feedback, whether in favor or against.

Thank you!

@robhudson
Copy link
Member Author

I looked more closely at popular Django apps and it isn't actually as common as I thought to include the django_ prefix in the module name for import. I think it's just that csp has such few words that it makes it feel like more of a scarce space.

Anyway, I'll close this. If there's ever any import path conflicts in the future we can reconsider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant