Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application should not be editable after creation #7083

Open
jaredlockhart opened this issue Feb 15, 2022 · 18 comments · May be fixed by #11985
Open

Application should not be editable after creation #7083

jaredlockhart opened this issue Feb 15, 2022 · 18 comments · May be fixed by #11985
Assignees
Labels
good-first-bug Good issues for people interested in contributing to Experimenter Outreachy

Comments

@jaredlockhart
Copy link
Collaborator

jaredlockhart commented Feb 15, 2022

I just noticed a test was updating application for a created experiment but that shouldn't be possible since that can invalidate other fields. Application should only be saveable on creation and our logic should prevent it from being changed, even in tests.

┆Issue is synchronized with this Jira Task

@eliserichards eliserichards added good-first-bug Good issues for people interested in contributing to Experimenter hacktoberfest 🎃 labels Oct 5, 2022
@cherish2003
Copy link
Contributor

Hello @yashikakhurana. I am an Outreachy applicant and I would love to participate in this experimenter project by working on this issue.

@yashikakhurana
Copy link
Contributor

@cherish2003 wanted to confirm again since other issue is assigned, once you finish that, I can assign it to you.

@cherish2003
Copy link
Contributor

@yashikakhurana okay mam

@prernadabi23
Copy link
Contributor

Hello, Can I take on this issue?
@yashikakhurana

@yashikakhurana
Copy link
Contributor

@prernadabi23 since I know you are having issue with your laptop, I am removing the assignment for now so it becomes available to be pick up by other applicant, meanwhile you can always tag me on the issue if its still not taken , thank you :)

@suhana832
Copy link

@yashikakhurana can I work on this task ?

@cherish2003
Copy link
Contributor

@yashikakhurana i want to work on this issue again can you assign me

@suhana832
Copy link

I just noticed a test was updating application for a created experiment but that shouldn't be possible since that can invalidate other fields. Application should only be saveable on creation and our logic should prevent it from being changed, even in tests.

┆Issue is synchronized with this Jira Task

can you provide screenshot or more details

@suhana832
Copy link

@jaredlockhart can you please elaborate the issue more ?

@yashikakhurana
Copy link
Contributor

@suhana832 As you will see in some of the test cases, python test cases- when we create an experiment, we pass the application too, but you will notice that in the same test case if you will try to update the application of the experiment, it will allow you to do so, but in actual it shouldn't let you modify application, test should fail, so we have to change our logic in the Django code, please let me know if you have any more questions

@suhana832
Copy link

i cant work on this issue : (

@cherish2003
Copy link
Contributor

@yashikakhurana can you specify the test file unable to locate it

@yashikakhurana
Copy link
Contributor

like in here-

, the idea is add a new test which only changes the application, it will pass now, but once you add a check/logic to not to allow it, your test will fail, which we exactly wants, and then you can update your newly added test and all the other test which should fail

@KramStyles
Copy link
Contributor

KramStyles commented Apr 10, 2023

@yashikakhurana I would love to work on this.
If I understand correctly, I should add a test to assert if the application can be updated after it's creation (which should not be allowed). Then I should update the logic in the main code to stop the application from been updated after been created?

Can this be assigned to me? Please provide me with any additional information or corrections. Thank you very much

@yashikakhurana
Copy link
Contributor

@KramStyles that's correct

@KramStyles
Copy link
Contributor

Hello @yashikakhurana ,

I'm sorry I've not made a push for this task. I've already started working on it but my PC crashed.

My docker really slowed down my system as it takes more than 10 minutes to start the application and 2 minutes for a reload. I read it's because docker runs over the WSL layer which can heavily affect its speed.

I decided to dual boot Linux and Windows so I can use Linux for the Experimenter project but in the process everything crashed.

Currently I'm trying to fix my laptop

@nox1134
Copy link
Contributor

nox1134 commented Jan 28, 2024

Hi @yashikakhurana! If no one is working on this issue, I'd like to work on it.
Could you please assign the issue to me?

@yashikakhurana
Copy link
Contributor

@nox1134 absolutely, thank you for your interest, let me know if you need any help 🙏

@yashikakhurana yashikakhurana assigned nox1134 and unassigned KramStyles Jan 29, 2024
@olamidepeterojo olamidepeterojo linked a pull request Dec 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-bug Good issues for people interested in contributing to Experimenter Outreachy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants