-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Application should not be editable after creation #7083
Comments
Hello @yashikakhurana. I am an Outreachy applicant and I would love to participate in this experimenter project by working on this issue. |
@cherish2003 wanted to confirm again since other issue is assigned, once you finish that, I can assign it to you. |
@yashikakhurana okay mam |
Hello, Can I take on this issue? |
@prernadabi23 since I know you are having issue with your laptop, I am removing the assignment for now so it becomes available to be pick up by other applicant, meanwhile you can always tag me on the issue if its still not taken , thank you :) |
@yashikakhurana can I work on this task ? |
@yashikakhurana i want to work on this issue again can you assign me |
can you provide screenshot or more details |
@jaredlockhart can you please elaborate the issue more ? |
@suhana832 As you will see in some of the test cases, python test cases- when we create an experiment, we pass the application too, but you will notice that in the same test case if you will try to update the application of the experiment, it will allow you to do so, but in actual it shouldn't let you modify application, test should fail, so we have to change our logic in the Django code, please let me know if you have any more questions |
i cant work on this issue : ( |
@yashikakhurana can you specify the test file unable to locate it |
like in here- Line 270 in b4824f9
|
@yashikakhurana I would love to work on this. Can this be assigned to me? Please provide me with any additional information or corrections. Thank you very much |
@KramStyles that's correct |
Hello @yashikakhurana , I'm sorry I've not made a push for this task. I've already started working on it but my PC crashed. My docker really slowed down my system as it takes more than 10 minutes to start the application and 2 minutes for a reload. I read it's because docker runs over the WSL layer which can heavily affect its speed. I decided to dual boot Linux and Windows so I can use Linux for the Experimenter project but in the process everything crashed. Currently I'm trying to fix my laptop |
Hi @yashikakhurana! If no one is working on this issue, I'd like to work on it. |
@nox1134 absolutely, thank you for your interest, let me know if you need any help 🙏 |
I just noticed a test was updating application for a created experiment but that shouldn't be possible since that can invalidate other fields. Application should only be saveable on creation and our logic should prevent it from being changed, even in tests.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: