Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a proper guard for useSavedMessages #48

Open
brennie opened this issue Jan 18, 2023 · 0 comments
Open

Add a proper guard for useSavedMessages #48

brennie opened this issue Jan 18, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@brennie
Copy link
Member

brennie commented Jan 18, 2023

The hook for useSavedMessages in #35 is a placeholder -- it always returns true. We should replace it with an actual guard to be typesafe.

We also might want to consider serializing the actual JSON messages instead of the formData when #15 lands. It is likely that the format of the form data will change but the actual message JSON is relatively stable.

@brennie brennie added the enhancement New feature or request label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant