Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid client side templating #1117

Open
zcorpan opened this issue Nov 20, 2024 · 1 comment
Open

Avoid client side templating #1117

zcorpan opened this issue Nov 20, 2024 · 1 comment
Labels

Comments

@zcorpan
Copy link
Member

zcorpan commented Nov 20, 2024

I would really prefer that we write the content directly into index.html during merge-data instead of loading the JSON at runtime and client side templating (to avoid some of the workarounds for fragment functionality etc). That said, we can work through that in followups, and this is overall a big simplification for the frontend (including removing many dependencies)

Originally posted by @bgrins in #1063 (comment)

@bgrins
Copy link
Member

bgrins commented Nov 20, 2024

And to be clear, I think we should also keep the json file around to make it easy to consume from other automated tooling. So we'd write JSON just like we do today, but update that script to also template out HTML to inject into index.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Unscreened
Development

No branches or pull requests

2 participants